More syscall fixes #3713
More syscall fixes #3713
Conversation
WalkthroughThe changes primarily involve updating system call invocations across multiple files from Changes
Sequence Diagram(s)sequenceDiagram
participant User as User
participant System as System Call
participant Function as Function Implementation
User->>Function: Call Function
Function->>System: Invoke syscall.SyscallN
System-->>Function: Return Results
Function-->>User: Return Results
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
Deploying wails with
|
| Latest commit: |
6dda981
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://aec60cfa.wails.pages.dev |
| Branch Preview URL: | https://v2-bugfix-more-syscall-fixes.wails.pages.dev |
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (5)
- v2/internal/frontend/desktop/windows/winc/w32/user32.go (6 hunks)
- v2/internal/frontend/desktop/windows/winc/w32/utils.go (2 hunks)
- v2/internal/frontend/desktop/windows/winc/w32/uxtheme.go (3 hunks)
- v2/internal/go-common-file-dialog/cfd/iFileOpenDialog.go (1 hunks)
- website/src/pages/changelog.mdx (1 hunks)
Files skipped from review due to trivial changes (1)
- website/src/pages/changelog.mdx
Additional comments not posted (14)
v2/internal/frontend/desktop/windows/winc/w32/uxtheme.go (3)
86-89: LGTM!The function is correctly updated to use
syscall.SyscallNfor better flexibility in handling arguments.The code changes are approved.
137-140: LGTM!The function is correctly updated to use
syscall.SyscallNfor better flexibility in handling arguments.The code changes are approved.
Line range hint
146-150: LGTM!The function is correctly updated to use
syscall.SyscallNfor better flexibility in handling arguments.The code changes are approved.
v2/internal/go-common-file-dialog/cfd/iFileOpenDialog.go (1)
167-170: LGTM!The function is correctly updated to use
syscall.SyscallNfor better flexibility in handling arguments.The code changes are approved.
v2/internal/frontend/desktop/windows/winc/w32/utils.go (3)
78-81: LGTM!The function is correctly updated to use
syscall.SyscallNfor better flexibility in handling arguments.The code changes are approved.
86-89: LGTM!The function is correctly updated to use
syscall.SyscallNfor better flexibility in handling arguments.The code changes are approved.
Line range hint
95-100: LGTM!The function is correctly updated to use
syscall.SyscallNfor better flexibility in handling arguments.The code changes are approved.
v2/internal/frontend/desktop/windows/winc/w32/user32.go (7)
Line range hint
642-646: LGTM!The change to
syscall.SyscallNis appropriate and improves flexibility.The code changes are approved.
795-798: LGTM!The change to
syscall.SyscallNis appropriate and improves flexibility.The code changes are approved.
835-837: LGTM!The change to
syscall.SyscallNis appropriate and improves flexibility.The code changes are approved.
1228-1230: LGTM!The change to
syscall.SyscallNis appropriate and improves flexibility.The code changes are approved.
1243-1246: LGTM!The change to
syscall.SyscallNis appropriate and improves flexibility.The code changes are approved.
1250-1253: LGTM!The change to
syscall.SyscallNis appropriate and improves flexibility.The code changes are approved.
1271-1274: LGTM!The change to
syscall.SyscallNis appropriate and improves flexibility.The code changes are approved.
Description
More syscall fixes for Windows. Should prevent issues on Go 1.23.
Summary by CodeRabbit
New Features
getResultsmethod to support dynamic argument counts for better compatibility and error management.Bug Fixes
Documentation