[v3 alpha] implement `setIcon` on linux #3354

abichinger · 2024-03-29T12:39:17Z

Description

This PR loads and displays application.Options.Icon on linux.

Type of change

New feature (non-breaking change which adds functionality)

How Has This Been Tested?

I have embedded a custom icon in a test project.

Windows
macOS
Linux

Test Configuration

# Build Environment
Wails CLI    | v3.0.0-alpha.4
                          
Go Version   | go1.22.0                                
Revision     | 238b9ede787b693705fc0a9a8f36da50ac44f6b2
Modified     | true                                    
-buildmode   | exe                                     
-compiler    | gc                                      
CGO_CFLAGS   |                                         
CGO_CPPFLAGS |                                         
CGO_CXXFLAGS |                                         
CGO_ENABLED  | 1                                       
CGO_LDFLAGS  |                                         
GOAMD64      | v1                                      
GOARCH       | amd64                                   
GOOS         | linux                                   
vcs          | git                                     
vcs.modified | true                                    
vcs.revision | 238b9ede787b693705fc0a9a8f36da50ac44f6b2
vcs.time     | 2024-03-26T10:11:35Z                    

# System
Name         | Manjaro Linux                                                                                                 
Version      | Unknown                                                                                                       
ID           | manjaro                                                                                                       
Branding     |                                                                                                               
Platform     | linux                                                                                                         
Architecture | amd64                                                                                                         
gcc          | 13.2.1-5                                                                                                      
libgtk-3     | 1:3.24.41-1                                                                                                   
libwebkit    | 2.42.5-2                                                                                                      
npm          | 10.5.0-1                                                                                                      
pkg-config   | 2.1.0-2                                                                                                       
CPU          | AMD Ryzen 5 3600 6-Core Processor                                                                             
GPU 1        | Navi 10 [Radeon RX 5600 OEM/5600 XT / 5700/5700 XT] (Advanced Micro Devices, Inc. [AMD/ATI]) - Driver: amdgpu 
Memory       | 32GB                                                                                                          

# Diagnosis
 SUCCESS  Your system is ready for Wails development!

Checklist:

I have updated website/src/pages/changelog.mdx with details of this PR
My code follows the general coding style of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes

coderabbitai · 2024-03-29T12:39:21Z

Important

Auto Review Skipped

Auto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

leaanthony · 2024-04-01T04:10:59Z

Thanks for doing this. Will test this week 👍

tmclane · 2024-04-03T22:34:27Z

I would request that you place this code in the cgo specific file linux_cgo.go file. The intent behind doing that is that it will make it easier to use purego as well as an alternate implementation.

tmclane · 2024-04-04T15:06:34Z

Thank you for implementing it! Appreciate the work!

I'll test it in a little while hopefully.

tmclane · 2024-04-09T14:36:40Z

v3/pkg/application/linux_cgo.go

@@ -1131,6 +1145,12 @@ func (w *linuxWebviewWindow) setTitle(title string) {
 	}
 }

+func (w *linuxWebviewWindow) setIcon(icon pointer) {
+	if icon != nil {
+		C.gtk_window_set_icon(w.gtkWindow(), (*C.GdkPixbuf)(icon))


Is setting a nil icon the method to remove the icon? Presumably

It is checked for nil, because there could go something wrong while loading the icon at linuxApp.setIcon. e.g. someone could set application.Options.Icon to an invalid image format

tmclane · 2024-04-09T15:22:11Z

My Manjaro does not show Icons it seems even with this change. Which desktop environment are you using? gnome?

tmclane · 2024-04-09T15:56:33Z

Actually I do see it now. Turns out I just wasn't able to override it in the code. Only shows up in the application overview where you can see all open windows.

abichinger · 2024-04-09T16:05:57Z

Which desktop environment are you using? gnome?

I'm using Xfce

leaanthony · 2024-04-11T11:05:55Z

Thanks @abichinger 🙏 Please could you retrospectively add an entry to the changelog located at mkdocs-website/docs/changelog.md? Thanks!

tmclane reviewed Apr 9, 2024

View reviewed changes

abichinger added 2 commits April 9, 2024 11:01

implement linuxApp.setIcon

8eebfa0

Move code into linux_cgo.go

b1a7aa2

tmclane force-pushed the feat/v3-set-icon-linux branch from 0f79664 to b1a7aa2 Compare April 9, 2024 16:02

tmclane merged commit 7c921d6 into wailsapp:v3-alpha Apr 9, 2024
4 checks passed

abichinger mentioned this pull request Apr 11, 2024

[v3 alpha] Changelog update for #3354 #3389

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[v3 alpha] implement `setIcon` on linux #3354

[v3 alpha] implement `setIcon` on linux #3354

abichinger commented Mar 29, 2024

coderabbitai bot commented Mar 29, 2024 •

edited

Loading

Auto Review Skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

leaanthony commented Apr 1, 2024

tmclane commented Apr 3, 2024

tmclane commented Apr 4, 2024 •

edited

Loading

tmclane Apr 9, 2024

abichinger Apr 9, 2024

tmclane commented Apr 9, 2024

tmclane commented Apr 9, 2024

abichinger commented Apr 9, 2024 •

edited

Loading

leaanthony commented Apr 11, 2024

[v3 alpha] implement setIcon on linux #3354

[v3 alpha] implement setIcon on linux #3354

Conversation

abichinger commented Mar 29, 2024

Description

Type of change

How Has This Been Tested?

Test Configuration

Checklist:

coderabbitai bot commented Mar 29, 2024 • edited Loading

Auto Review Skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

leaanthony commented Apr 1, 2024

tmclane commented Apr 3, 2024

tmclane commented Apr 4, 2024 • edited Loading

tmclane Apr 9, 2024

Choose a reason for hiding this comment

abichinger Apr 9, 2024

Choose a reason for hiding this comment

tmclane commented Apr 9, 2024

tmclane commented Apr 9, 2024

abichinger commented Apr 9, 2024 • edited Loading

leaanthony commented Apr 11, 2024

[v3 alpha] implement `setIcon` on linux #3354

[v3 alpha] implement `setIcon` on linux #3354

coderabbitai bot commented Mar 29, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)

tmclane commented Apr 4, 2024 •

edited

Loading

abichinger commented Apr 9, 2024 •

edited

Loading