[linux] fix closing of custom context menu #3329

[abichinger]

Description

• Add linuxWebviewWindow.ctxMenuOpened to track if a custom context menu was opened
• connect the button-release-event signal to the menu

Fixes #3329

Type of change

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Running examples/contextmenus

• Windows
• macOS
• Linux

Test Configuration

# Build Environment
Wails CLI    | v3.0.0-alpha.3                          
Go Version   | go1.22.0                                
Revision     | 33946a7aace91ffb1a3992dcf3af7a2071ac70d2
Modified     | true                                    
-buildmode   | exe                                     
-compiler    | gc                                      
CGO_CFLAGS   |                                         
CGO_CPPFLAGS |                                         
CGO_CXXFLAGS |                                         
CGO_ENABLED  | 1                                       
CGO_LDFLAGS  |                                         
GOAMD64      | v1                                      
GOARCH       | amd64                                   
GOOS         | linux                                   
vcs          | git                                     
vcs.modified | true                                    
vcs.revision | 33946a7aace91ffb1a3992dcf3af7a2071ac70d2
vcs.time     | 2024-03-19T10:56:54Z                    

# System
Name         | Manjaro Linux                                                                                                 
Version      | Unknown                                                                                                       
ID           | manjaro                                                                                                       
Branding     |                                                                                                               
Platform     | linux                                                                                                         
Architecture | amd64                                                                                                         
gcc          | 13.2.1-5                                                                                                      
libgtk-3     | 1:3.24.41-1                                                                                                   
libwebkit    | 2.42.5-2                                                                                                      
npm          | 10.5.0-1                                                                                                      
pkg-config   | 2.1.0-2                                                                                                       
CPU          | AMD Ryzen 5 3600 6-Core Processor                                                                             
GPU 1        | Navi 10 [Radeon RX 5600 OEM/5600 XT / 5700/5700 XT] (Advanced Micro Devices, Inc. [AMD/ATI]) - Driver: amdgpu 
Memory       | 32GB                                                                                                          

# Diagnosis
 SUCCESS  Your system is ready for Wails development!

Checklist:

• I have updated website/src/pages/changelog.mdx with details of this PR
• My code follows the general coding style of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

[coderabbitai]

Important

Auto Review Skipped

Auto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[tmclane]

Looks good but I can't validate it on Manjaro.

[atterpac]

Tested and confirmed working in the following environment (Ubuntu 22.02)

# Build Environment
Wails CLI    | v3.0.0-alpha.3
Go Version   | go1.21.4
-buildmode   | exe
-compiler    | gc
CGO_CFLAGS   |
CGO_CPPFLAGS |
CGO_CXXFLAGS |
CGO_ENABLED  | 1
CGO_LDFLAGS  |
GOAMD64      | v1
GOARCH       | amd64
GOOS         | linux

# System
Name         | Ubuntu
Version      | 22.04
ID           | ubuntu
Branding     | 22.04.3 LTS (Jammy Jellyfish)
Platform     | linux
Architecture | amd64
gcc          | 12.9ubuntu3
libgtk-3     | 3.24.33-1ubuntu2
libwebkit    | 2.42.5-0ubuntu0.22.04.2
npm          | 8.5.1~ds-1
pkg-config   | 0.29.2-1ubuntu3
CPU          | 12th Gen Intel(R) Core(TM) i5-1235U
GPU 1        | unknown (Intel Corporation) - Driver: i915
Memory       | 7GB

[leaanthony]

Thanks 🙏 Please could you add an entry to the changelog located at mkdocs-website/docs/changelog.md? Thanks!

[abichinger]

Done :)

[leaanthony]

Thanks for doing this.