Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/template consolidation #3046

Merged
merged 7 commits into from
Nov 11, 2023
Merged

Conversation

tmclane
Copy link
Member

@tmclane tmclane commented Nov 10, 2023

  • Removed the duplicate files from each of the included template directories
  • Update the list of templates dynamically out of the embed.FS
  • Pull the description of the templates from template's template.json file
  • Add Linux build target to the Taskfile.yaml in _common

- uses a single fs.Embed to contain all templates
- walks and rebuilds the list of TemplateData using the cached data
- pulls the `description` out of the required `template.json` file in
  the template directory
- move "common" template files to a _common directory
- update generator to render from _common/* first
- render selected template last to overwrite anything provided by
  _common if needed
- remove duplicate files from all templates that do not change
@tmclane tmclane added the v3 label Nov 10, 2023
@tmclane tmclane requested a review from leaanthony November 10, 2023 05:30
@tmclane tmclane changed the base branch from master to v3-alpha November 10, 2023 05:30
@tmclane tmclane added this to the v3.0.0 milestone Nov 10, 2023
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: e284a53
Status: ✅  Deploy successful!
Preview URL: https://2949b279.wails.pages.dev
Branch Preview URL: https://feature-template-consolidati.wails.pages.dev

View logs

Copy link
Member

@leaanthony leaanthony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tmclane !!!!

@leaanthony leaanthony merged commit b8d780b into v3-alpha Nov 11, 2023
@leaanthony leaanthony deleted the feature/template-consolidation branch November 11, 2023 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants