Add extra check for GPU device info for null pointer #3032
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When running doctor, the github.com/jaypipes/ghw package currently is used to run a GPU check for device info but in the edge case where the user doesn't have drivers installed, the package causes a null pointer error which is not handled properly.
I added an extra check in case the user doesn't have drivers installed to return the correct information which results in "unknown" for bad installation and normal results if everything is correct.
Fixes # (issue)
I haven't submitted an issue for this one yet sorry as this is likely only impacting me currently as I was messing with my WSL install but though I should submit PR to handle this edge case anway, do I need to submit one?
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration using
wails doctor
.Results from my WSL install:
Test Configuration
N/A
Checklist:
website/src/pages/changelog.mdx
with details of this PR