Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added possibility to specify platform for dev command #2724

Closed
wants to merge 3 commits into from

Conversation

evsign
Copy link

@evsign evsign commented Jun 12, 2023

Description

During development under Wsl, there is currently no way to use the wails dev command to build a Windows executable and I thought that it would be nice and convenient to have such. These changes allow specifying the platform for the wails dev command. Example: wails dev --platform=windows.

Currently, there is no open issue for this feature. If it needs to be created, please let me know, and I'll create it.

Type of change

  • New feature (non-breaking change which adds functionality)

@evsign evsign force-pushed the feature/dev-platform branch from b259ce2 to 94039df Compare June 14, 2023 07:53
@leaanthony
Copy link
Member

Hi! Thanks for taking the time to open this. Could you please open a ticket and detail the scenarios in which this might be used? I'm not familiar with wsl or what this use case looks like. Thanks! 🙏

@leaanthony leaanthony added the awaiting feedback More information is required from the requestor label Jul 1, 2023
@leaanthony
Copy link
Member

Hi, this is Tisso, where have you gone) Write to tg Krdgoblin

Please stop.

@PylotLight
Copy link
Contributor

@leaanthony This would actually be super useful. Currently wails dev run through WSL loads a Linux app which looks poor is annoying to interact with and doesn't work in some cases where Linux GUI apps are not supported in WSL. If we could instead direct dev to launch a windows app, that would be way better.

image

@leaanthony
Copy link
Member

What's the advantage of Dev in WSL vs just plain windows? Windows is by far the better supported platform.

@PylotLight
Copy link
Contributor

It's widely accepted that working and coding in Linux is a far superior platform and experience for a variety of reasons. For those of us who need or want Linux but still need some of the features of windows for daily use then WSL allows us to have the best of both worlds. This would be a very long comment if you want me to explain why WSL is useful or beneficial, but myself and many others, have been using it for years.

@leaanthony
Copy link
Member

Thanks 🙏 Please could you add an entry to the changelog located at website/src/pages/changelog.mdx?

@PylotLight
Copy link
Contributor

@evsign Can you finish this one off plz. 🙏

@PylotLight
Copy link
Contributor

@leaanthony Would need a rebase by now. Perhaps we either just copy the changes into a new PR and close this one. Or just close as this is in v3 already anyway?

@leaanthony
Copy link
Member

If you want to take over this PR we could look at it?

@PylotLight
Copy link
Contributor

PylotLight commented Dec 11, 2023

@leaanthony Sure. Just need to update feature/dev-platform correct?
I updated my local wails repo (there was only 1 tiny merge conflict) cause I forgot I don't have access to push from that, so just need to do the same thing from my fork I think, not sure how that connects into this PR tho.

@PylotLight
Copy link
Contributor

Created working copy: #3117

@leaanthony
Copy link
Member

Closing in favour of: #3117

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting feedback More information is required from the requestor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants