Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dev] Do not try to infer assetdir from fs.FS when a frontend dev server is in use #1972

Merged
merged 1 commit into from
Oct 13, 2022
Merged

[dev] Do not try to infer assetdir from fs.FS when a frontend dev server is in use #1972

merged 1 commit into from
Oct 13, 2022

Conversation

stffabi
Copy link
Collaborator

@stffabi stffabi commented Oct 13, 2022

Fixes #1971

@stffabi stffabi mentioned this pull request Oct 13, 2022
Closed
leaanthony
leaanthony approved these changes Oct 13, 2022
View reviewed changes
Copy link
Member

@leaanthony leaanthony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@leaanthony leaanthony merged commit 7f733d7 into wailsapp:master Oct 13, 2022
@stffabi stffabi deleted the feature/dev-no-assetdirinfer-frontendserver branch October 18, 2022 07:31
@coderabbitai coderabbitai bot mentioned this pull request Apr 22, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leaanthony leaanthony leaanthony approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error: no index.html found
2 participants
@stffabi @leaanthony