Allow -appargs flag to pass flags to binary. #1534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome Ian 👍 I've no better suggestions right now so let's go for it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1533
This change allows
-appargsto pass flags to the binary when usingwails dev.This is needed because if you do not set "assetdir" in
wails.jsonthen theAppcreated bywails devtries to check the command line flags for-assetdirand a few more flags, and then fails when it finds the app specific flag being passed on the command line which is unknown to the flagset being used in the devCreateApp.The only way I could figure out to achieve this was to use a distinct FlagSet and set it to continue on error. I think this is ok as it only applies to running via
wails dev, but wouldn't be too upset if someone has a better solution! 😄There's a bonus typo fix in the help message for
-appargsand gofmt fixes included for good measure too.