Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Window Background colour if provided + debounce redraw option #1466

Merged
merged 2 commits into from
Jun 20, 2022

Conversation

leaanthony
Copy link
Member

@leaanthony leaanthony commented Jun 19, 2022

Sets window background colour if provided.
Added ResizeDebounceMS for specifying the delay before redraw when resizing.

This PR provides options to decrease the "flicker" when resizing the app on Windows.

@leaanthony leaanthony requested a review from stffabi June 19, 2022 09:20
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jun 19, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: bb485b9
Status: ✅  Deploy successful!
Preview URL: https://b443a0b1.wails-website.pages.dev
Branch Preview URL: https://feature-better-window-redraw.wails-website.pages.dev

View logs

Copy link
Collaborator

@stffabi stffabi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great we now have a flicker free resizing on Windows 🚀.

I've also added a commit to workaround the flickering in Frameless mode.

@leaanthony leaanthony merged commit cb16961 into master Jun 20, 2022
@leaanthony leaanthony deleted the feature/better-window-redraw branch June 20, 2022 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants