Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for 'DomReady' callback on linux #1249

Merged
merged 3 commits into from
Mar 14, 2022

Conversation

napalu
Copy link
Contributor

@napalu napalu commented Mar 12, 2022

cosmetic: use bodyLen instead of len() in processRequest()

cosmetic: use bodyLen instead of len() in processRequest()
@napalu
Copy link
Contributor Author

napalu commented Mar 12, 2022

A small nitpick: the term "DomReady" is in my opinion misleading because it suggests an equivalence to javascript's 'DOMContentLoaded' whereas 'DomReady' is emitted when navigation has finished loading. Maybe the description and name of the go callback should be changed to reflect this?

@napalu
Copy link
Contributor Author

napalu commented Mar 13, 2022

fixes #1246

@leaanthony leaanthony merged commit d9e5cce into wailsapp:master Mar 14, 2022
@leaanthony
Copy link
Member

A small nitpick: the term "DomReady" is in my opinion misleading because it suggests an equivalence to javascript's 'DOMContentLoaded' whereas 'DomReady' is emitted when navigation has finished loading. Maybe the description and name of the go callback should be changed to reflect this?

That's a valid point. Originally it was to indicate that elements of the page were ready, including the runtime but I agree the name is now misleading. What would you call it?

@napalu
Copy link
Contributor Author

napalu commented Mar 14, 2022

Something like resourcesLoaded might be more appropriate - currently the comment to describe domReady after wails init is run reads: domReady is called after the front-end dom has been loaded.

I suppose we could leave the name as-is and just alter the comment to read domReady is called after front-end resources have been loaded - what do you think?

@napalu napalu deleted the bugfix/linux_domready_callback branch March 14, 2022 11:38
@leaanthony
Copy link
Member

Updated comments in templates + website. Thanks for all your contributions 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants