[v2] Only call EnableSizable for normal windows #1074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stffabi
commented
Jan 14, 2022
stffabi
force-pushed
the
feature/frameless-resizing
branch
from
4e6135e
to
3fb9e56
Compare
stffabi
force-pushed
the
feature/frameless-resizing
branch
3 times, most recently
from
e2a385c
to
21e25d5
Compare
|
I've just merged your PR on winc. Does this need updating again? 😆 |
Frameless windows are always not resizable per default and the resizing for those will be initiated by the frontend see processMessage. If EnableSizable is enabled for frameless windows, a small white titlebar will be shown. Fix wailsapp#1049
Contains fixes for wailsapp#1049, wailsapp#1063 and wailsapp#1083
stffabi
force-pushed
the
feature/frameless-resizing
branch
from
21e25d5
to
dd4b0e1
Compare
|
I've just updated it to contain leaanthony/winc#12 |
|
Glad to finally get this one over the line :-) |
|
😄 Thanks for merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Frameless windows are always not resizable per default and
the resizing for those will be initiated by the frontend see
processMessage.
If EnableSizable is enabled for frameless windows, a small white
titlebar will be shown.
Fix #1049