fix syso icon generation (#3675)

update changelog.md
wailsapp · Aug 9, 2024 · cfab21b · cfab21b
1 parent d405bd4
commit cfab21b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/mkdocs-website/docs/en/changelog.md b/mkdocs-website/docs/en/changelog.md
@@ -17,6 +17,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+### Fixed
+- [windows] Fixed syso icon file generation bug by [atterpac](https://github.com/atterpac) in [#3675](https://github.com/wailsapp/wails/pull/3675)
+
 ## v3.0.0-alpha.6 - 2024-07-30
 
 ### Fixed 

diff --git a/v3/internal/commands/syso.go b/v3/internal/commands/syso.go
@@ -44,7 +44,7 @@ func GenerateSyso(options *SysoOptions) (err error) {
 	}
 	defer func() {
 		err2 := iconFile.Close()
-		if err == nil {
+		if err2 != nil {
 			err = errors.Wrap(err, "error closing icon file: "+err2.Error())
 		}
 	}()