-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wagtail 4.0 upgrade #265
Merged
Merged
Wagtail 4.0 upgrade #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcdickinson
force-pushed
the
wagtail-4.0
branch
from
September 29, 2022 16:31
6be89ac
to
be332a4
Compare
zerolab
reviewed
Sep 29, 2022
bcdickinson
force-pushed
the
wagtail-4.0
branch
3 times, most recently
from
September 30, 2022 09:54
3518029
to
4a3b224
Compare
Closed
bcdickinson
force-pushed
the
wagtail-4.0
branch
4 times, most recently
from
October 4, 2022 13:59
538c5c7
to
7821178
Compare
zerolab
reviewed
Oct 4, 2022
zerolab
reviewed
Oct 4, 2022
zerolab
reviewed
Oct 4, 2022
zerolab
reviewed
Oct 4, 2022
zerolab
reviewed
Oct 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The vast majority of changes make sense 👍
Left a number of comments/questions
bcdickinson
force-pushed
the
wagtail-4.0
branch
from
October 4, 2022 15:00
8bf8046
to
1d6f2dc
Compare
zerolab
reviewed
Oct 4, 2022
bcdickinson
force-pushed
the
wagtail-4.0
branch
from
October 5, 2022 08:02
b535f6a
to
d628f8a
Compare
zerolab
reviewed
Oct 5, 2022
bcdickinson
force-pushed
the
wagtail-4.0
branch
from
October 5, 2022 08:25
08f4437
to
24ca9cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades the project and it's dependencies (as far as possible) to be compatible with Wagtail 4.0.
To make life easier for myself in terms of being able to easily detect incompatible versions and improve build reproducability, I migrated from
pip
/requirements.txt topoetry==1.2.1
for dependency management first.I hit the following snags while upgrading the various
wagtail*
3rd party packages:wagtail-ab-testing
explicitly does not supportwagtail>=3
sopoetry
refuses to install it. The are open PRs to add support (hat tip to @nickmoreton), but they didn't make it in in time for this PR, so for the time being I've just removed A/B testing from this project.wagtail-airtable
has some incompatibiliites with Wagtail 4.0 so the sync currently doesn't work and should not be used. I've elected not to remove it at this point to avoid losing theairtable_record_id
data onAirtableMixin
subclasses.wagtail-content-import
,wagtail-image-import
, andwagtailaltgenerator
all superficially appear to be compatible with Wagtail 4.0 with the caveat that I haven't done extensive manual testing and the packages themselves don't officially support or test against it.wagtail-transfer
doesn't officially support or explicitly test against Wagtail 4.0, but the nightly builds againstmain
are currently passing, so we're on pretty safe ground herewagtailmedia
is fine, it explicitly supports and tests against Wagtail 4.0I've raised tickets to reinstate
wagtail-ab-testing
following it being brought up to date and to add 4.0 support towagtail-airtable
.