Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wagtail 4.0 upgrade #265

Merged
merged 20 commits into from
Oct 6, 2022
Merged

Wagtail 4.0 upgrade #265

merged 20 commits into from
Oct 6, 2022

Conversation

bcdickinson
Copy link

@bcdickinson bcdickinson commented Sep 29, 2022

This PR upgrades the project and it's dependencies (as far as possible) to be compatible with Wagtail 4.0.

To make life easier for myself in terms of being able to easily detect incompatible versions and improve build reproducability, I migrated from pip/requirements.txt to poetry==1.2.1 for dependency management first.

I hit the following snags while upgrading the various wagtail* 3rd party packages:

  • wagtail-ab-testing explicitly does not support wagtail>=3 so poetry refuses to install it. The are open PRs to add support (hat tip to @nickmoreton), but they didn't make it in in time for this PR, so for the time being I've just removed A/B testing from this project.
  • wagtail-airtable has some incompatibiliites with Wagtail 4.0 so the sync currently doesn't work and should not be used. I've elected not to remove it at this point to avoid losing the airtable_record_id data on AirtableMixin subclasses.
  • wagtail-content-import, wagtail-image-import, and wagtailaltgenerator all superficially appear to be compatible with Wagtail 4.0 with the caveat that I haven't done extensive manual testing and the packages themselves don't officially support or test against it.
  • wagtail-transfer doesn't officially support or explicitly test against Wagtail 4.0, but the nightly builds against main are currently passing, so we're on pretty safe ground here
  • wagtailmedia is fine, it explicitly supports and tests against Wagtail 4.0

I've raised tickets to reinstate wagtail-ab-testing following it being brought up to date and to add 4.0 support to wagtail-airtable.

@bcdickinson bcdickinson changed the base branch from main to next September 29, 2022 15:58
Dockerfile Outdated Show resolved Hide resolved
@bcdickinson bcdickinson force-pushed the wagtail-4.0 branch 3 times, most recently from 3518029 to 4a3b224 Compare September 30, 2022 09:54
@zerolab zerolab mentioned this pull request Sep 30, 2022
@bcdickinson bcdickinson force-pushed the wagtail-4.0 branch 4 times, most recently from 538c5c7 to 7821178 Compare October 4, 2022 13:59
pyproject.toml Show resolved Hide resolved
Makefile Show resolved Hide resolved
Copy link
Contributor

@zerolab zerolab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The vast majority of changes make sense 👍

Left a number of comments/questions

Makefile Show resolved Hide resolved
@bcdickinson bcdickinson requested a review from zerolab October 5, 2022 07:38
@bcdickinson bcdickinson marked this pull request as ready for review October 5, 2022 07:38
pyproject.toml Outdated Show resolved Hide resolved
@zerolab zerolab merged commit 1878d6f into next Oct 6, 2022
@zerolab zerolab deleted the wagtail-4.0 branch October 6, 2022 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants