-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maintenance, support for Wagtail 6.2, format with ruff, switch to pyproject.toml
#87
Conversation
26728b2
to
dd494a4
Compare
...and explain why raw SQL is necessary. Too bad Django does not support atomic upserts!
3c4de1a
to
3333998
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #87 +/- ##
==========================================
+ Coverage 88.44% 93.45% +5.01%
==========================================
Files 15 42 +27
Lines 753 1620 +867
Branches 140 163 +23
==========================================
+ Hits 666 1514 +848
- Misses 51 69 +18
- Partials 36 37 +1 ☔ View full report in Codecov by Sentry. |
@mgax would you mind reviewing this? I know it's a lot, but your help goes a long way 🫶 This fixes the report view in Wagtail 6.2 – I'm sure a particular client of yours is interested in that 😄 |
3333998
to
ff66b6f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much props for doing all this work! I've left a few small comments.
Python 3.8 support will end officially next month on October 31st. We'll drop now because it prevents us from fixing removing our use of `datetime.utcnow()`.
ff66b6f
to
625dd8c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff! 👏
625dd8c
to
792167b
Compare
Thanks so much Alex! This has now been released: https://pypi.org/project/wagtail-ab-testing/0.11/ |
@Stormheg thanks for doing all the work! |
No description provided.