-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wagtail 3.0 compatibility #48
Closed
Closed
Changes from 12 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
b2570ac
Run wagtail updatemodulepaths
nickmoreton 7057e05
don't pass the request to render_html in Wagtail >=3.0
nickmoreton 4270456
Use conditional to get comparison for Wagtail 3.0
nickmoreton ee84fde
Use conditional to check if the request is passed in addition to context
nickmoreton df77c21
Django 4+ compatibility, use path in place of url
nickmoreton 6395e06
Refactor render_html method
nickmoreton 36aaa15
Refactor is_shown method
nickmoreton 8ec3e85
Tody up method calls
nickmoreton 143a64a
Adjust testmanage.py
nickmoreton 81430cd
Bump django and wagtail versions
nickmoreton f967dd6
Update README and CHANGELOG
nickmoreton 6de0840
Alter imports for project consistency
nickmoreton 8965b34
Change to use version number checks
nickmoreton 5630045
Quiet WAGTAILADMIN_BASE_URL warning during tests
nickmoreton 3d437d4
Be more consistent checking the wagtail version
nickmoreton e3a1fef
Remove unused import
nickmoreton File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,20 +1,24 @@ | ||
from django.conf.urls import include, url | ||
from django.urls import include, path | ||
from django.contrib import admin | ||
|
||
from wagtail.admin import urls as wagtailadmin_urls | ||
from wagtail.documents import urls as wagtaildocs_urls | ||
from wagtail.core import urls as wagtail_urls | ||
|
||
try: | ||
from wagtail import urls as wagtail_urls | ||
except ImportError: | ||
from wagtail.core import urls as wagtail_urls | ||
|
||
from wagtail_ab_testing import api as ab_testing_api | ||
from wagtail_ab_testing import urls as ab_testing_urls | ||
|
||
|
||
urlpatterns = [ | ||
url(r"^django-admin/", admin.site.urls), | ||
url(r"^admin/", include(wagtailadmin_urls)), | ||
url(r"^documents/", include(wagtaildocs_urls)), | ||
url(r'^abtestingapi/', include(ab_testing_api, namespace='ab_testing_api')), | ||
url(r'^abtesting/', include(ab_testing_urls, namespace='wagtail_ab_testing')), | ||
path("django-admin/", admin.site.urls), | ||
path("admin/", include(wagtailadmin_urls)), | ||
path("documents/", include(wagtaildocs_urls)), | ||
path('abtestingapi/', include(ab_testing_api, namespace='ab_testing_api')), | ||
path('abtesting/', include(ab_testing_urls, namespace='wagtail_ab_testing')), | ||
|
||
url(r"", include(wagtail_urls)), | ||
path("", include(wagtail_urls)), | ||
] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a major release, right? We need to add the new version number here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the final release number should now be 1.0.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay cool.