Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rendering for multi-line commands #443

Merged
merged 1 commit into from
Jul 6, 2023
Merged

Conversation

lutzky
Copy link
Contributor

@lutzky lutzky commented Apr 14, 2023

Heredocs can be used to create multi-line commands, which broke rendering.

Details about heredocs: https://www.docker.com/blog/introduction-to-heredocs-in-dockerfiles/

Before:

image

After:

image

(Example is adapted from https://fasterthanli.me/series/building-a-rust-service-with-nix/part-6)

@mark2185
Copy link
Contributor

Check out #399 as well, might prove useful.

@lutzky lutzky mentioned this pull request Apr 14, 2023
@lutzky
Copy link
Contributor Author

lutzky commented Apr 14, 2023

Thanks, I've left a comment on #399: https://github.com/wagoodman/dive/pull/399/files#r1166837287

I believe the run-static-analyses failure is unrelated to my change.

@mark2185
Copy link
Contributor

I believe the run-static-analyses failure is unrelated to my change.

I don't want to be the bearer of bad news, but the project has been inactive for a while.

@lutzky
Copy link
Contributor Author

lutzky commented Apr 14, 2023

Damn ^_^

Oh well, I thought it'd be a useful thing. I've only encountered it as part of
https://fasterthanli.me/series/building-a-rust-service-with-nix/part-6, so I figured I'd fix it as I go 🤷

Heredocs can be used to create multi-line commands, which broke rendering.

Details about heredocs: https://www.docker.com/blog/introduction-to-heredocs-in-dockerfiles/
Copy link
Owner

@wagoodman wagoodman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the enhancement here! (force pushed to rebase)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants