Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quit on q #352

Closed
abitrolly opened this issue Apr 18, 2021 · 0 comments · Fixed by #354
Closed

Quit on q #352

abitrolly opened this issue Apr 18, 2021 · 0 comments · Fixed by #354
Labels
enhancement Add a new feature

Comments

@abitrolly
Copy link
Contributor

I tried to add this, but it fails with the error.

Building cache...
could not parse keybinding ' q' from request 'ctrl+c, q': unsupported keybinding: KeyQ

diff --git a/cmd/root.go b/cmd/root.go
index 03086b1..6a6a278 100644
--- a/cmd/root.go
+++ b/cmd/root.go
@@ -77,7 +77,7 @@ func initConfig() {
        viper.SetDefault("log.path", "./dive.log")
        viper.SetDefault("log.enabled", false)
        // keybindings: status view / global
-       viper.SetDefault("keybinding.quit", "ctrl+c")
+       viper.SetDefault("keybinding.quit", "ctrl+c, q")
        viper.SetDefault("keybinding.toggle-view", "tab")
        viper.SetDefault("keybinding.filter-files", "ctrl+f, ctrl+slash")
        // keybindings: layer view
abitrolly referenced this issue in awesome-gocui/keybinding Apr 18, 2021
@glvr182
Added character support
864552b 
Signed-off-by: Glenn Vriesman <[email protected]>
abitrolly added a commit to abitrolly/dive that referenced this issue May 7, 2021
@abitrolly
Fix wagoodman#352. Quit on q
699e3fc 
This uses latest `github.com/awesome-gocui/keybinding`
It will also be possible to separate quit shortcuts by space when
awesome-gocui/keybinding#3 is merged.
@abitrolly abitrolly mentioned this issue Oct 11, 2021
Merged
mark2185 pushed a commit to mark2185/dive that referenced this issue Apr 29, 2022
@abitrolly @mark2185
Fix wagoodman#352. Quit on q
11f866b 
This uses latest `github.com/awesome-gocui/keybinding`
It will also be possible to separate quit shortcuts by space when
awesome-gocui/keybinding#3 is merged.
wagoodman pushed a commit to abitrolly/dive that referenced this issue Jul 6, 2023
@abitrolly @wagoodman
Fix wagoodman#352. Quit on q
621e677 
This uses latest `github.com/awesome-gocui/keybinding`
It will also be possible to separate quit shortcuts by space when
awesome-gocui/keybinding#3 is merged.
wagoodman added a commit that referenced this issue Jul 6, 2023
@wagoodman
Merge pull request #354 from abitrolly/master
b696153 
Fix #352. Quit on `q`
@wagoodman wagoodman added the enhancement Add a new feature label Jul 7, 2023
This was referenced Jul 7, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Add a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #352. Quit on q abitrolly/dive
2 participants
@wagoodman @abitrolly