Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue931 onset-to-onset timewindow #933

Merged
merged 18 commits into from
Oct 12, 2023
Merged

Issue931 onset-to-onset timewindow #933

merged 18 commits into from
Oct 12, 2023

Conversation

jhmigueles
Copy link
Collaborator

@jhmigueles jhmigueles commented Oct 5, 2023

Closes #931 => Allow for the calculation of sleep onset to sleep onset windows ("OO") in part 5.

Checklist before merging:

  • Existing tests still work (check by running the test suite, e.g. from RStudio).
  • Added tests (if you added functionality) or fixed existing test (if you fixed a bug).
  • Updated or expanded the documentation.
  • Updated release notes in inst/NEWS.Rd with a user-readable summary. Please, include references to relevant issues or PR discussions.
  • Added your name to the contributors lists in the DESCRIPTION and CITATION.cff files.

@codecov-commenter
Copy link

Codecov Report

Merging #933 (050d549) into master (0e67881) will increase coverage by 0.03%.
The diff coverage is 90.90%.

❗ Current head 050d549 differs from pull request most recent head 0069997. Consider uploading reports for the commit 0069997 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##           master     #933      +/-   ##
==========================================
+ Coverage   78.18%   78.21%   +0.03%     
==========================================
  Files          93       93              
  Lines       12334    12352      +18     
==========================================
+ Hits         9643     9661      +18     
  Misses       2691     2691              
Files Coverage Δ
R/g.part5.R 79.92% <100.00%> (+0.28%) ⬆️
R/g.part5.definedays.R 82.05% <100.00%> (+1.86%) ⬆️
R/g.report.part5.R 85.24% <50.00%> (ø)

@vincentvanhees vincentvanhees mentioned this pull request Oct 11, 2023
5 tasks
@vincentvanhees vincentvanhees merged commit 46c633e into master Oct 12, 2023
8 checks passed
@vincentvanhees vincentvanhees deleted the issue931_OOwindow branch October 12, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Onset-to-Onset timewindow
3 participants