Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

data_quality_report when rerunning parts 1 and 2 #899

Merged
merged 2 commits into from
Sep 11, 2023
Merged

data_quality_report when rerunning parts 1 and 2 #899

merged 2 commits into from
Sep 11, 2023

Conversation

jhmigueles
Copy link
Collaborator

@jhmigueles jhmigueles commented Sep 8, 2023 •
edited
Loading

Fixes #896 => After rerunning parts 1 and 2 with overwrite = TRUE and backup.cal.coef = "retrieve", the QC message and the calibration errors were not stored appropriately. This has been fixed now.

Checklist before merging:

  • Existing tests still work (check by running the test suite, e.g. from RStudio).
  • Added tests (if you added functionality) or fixed existing test (if you fixed a bug).
  • Updated or expanded the documentation.
  • Updated release notes in inst/NEWS.Rd with a user-readable summary. Please, include references to relevant issues or PR discussions.
  • Added your name to the contributors lists in the DESCRIPTION and CITATION.cff files.

@vincentvanhees vincentvanhees merged commit 406d939 into master Sep 11, 2023
8 checks passed
@vincentvanhees vincentvanhees deleted the issue896_DQreport branch September 13, 2023 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincentvanhees vincentvanhees vincentvanhees approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

data_quality_report.csv messed up when re-running part 2
2 participants
@jhmigueles @vincentvanhees