Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix handling of DST in the autumn in GGIR part 3. #1227

Merged
merged 2 commits into from
Nov 21, 2024
Merged

Fix handling of DST in the autumn in GGIR part 3. #1227

merged 2 commits into from
Nov 21, 2024

Conversation

vincentvanhees
Copy link
Member

@vincentvanhees vincentvanhees commented Nov 19, 2024 •
edited
Loading

Fixes #1225

Based on positive feedback from Jairo I am now drafting this PR and probably merge it by the end of the week.

Checklist before merging:

  • Existing tests still work (check by running the test suite, e.g. from RStudio).
  • Added tests (if you added functionality) or fixed existing test (if you fixed a bug).
  • Clean code has been attempted, e.g. intuitive object names and no code redundancy.
  • Documentation updated:
    • Function documentation
    • Chapter vignettes for GitHub IO
    • Vignettes for CRAN
  • Corresponding issue tagged in PR message. If no issue exist, please create an issue and tag it.
  • Updated release notes in inst/NEWS.Rd with a user-readable summary. Please, include references to relevant issues or PR discussions.
  • Added your name to the contributors lists in the DESCRIPTION file, if you think you made a significant contribution.
  • GGIR parameters were added/removed. If yes, please also complete checklist below.

@vincentvanhees vincentvanhees marked this pull request as ready for review November 19, 2024 12:39
@vincentvanhees vincentvanhees merged commit e98af24 into master Nov 21, 2024
7 checks passed
@vincentvanhees vincentvanhees deleted the issue1225_DST_part3 branch November 21, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Part 4: Error in if (is.na(defaultGuider)) { : argument is of length zero`
1 participant
@vincentvanhees