Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy to fire base step is failing. #38

Closed
Kuncheria-Kuruvilla opened this issue May 1, 2020 · 5 comments
Closed

Deploy to fire base step is failing. #38

Kuncheria-Kuruvilla opened this issue May 1, 2020 · 5 comments

Comments

@Kuncheria-Kuruvilla
Copy link

Kuncheria-Kuruvilla commented May 1, 2020

Firebase deploy is failing with the following error
Specified public directory 'build' does not exist, can't deploy hosting to site my-site.

workflow.yml

@mrsimpson
Copy link

you should configure the path to your build in your firebase.json so that the CLI can pick it up.
If you do not want hosting on GCP, you can also completely remove the hosting section.

@peterpeterparker
Copy link

peterpeterparker commented May 1, 2020

same to me with dist which I've got it in my firebase.json.

{
  "hosting": {
    "public": "dist",

my yml file

Error:

i  deploying hosting

Error: Specified public directory 'dist' does not exist, can't deploy hosting to site deckdeckgo-website

@peterpeterparker
Copy link

peterpeterparker commented May 1, 2020

Found the solution. actions/download-artifact v2 was released three days ago. Don't know if it's a not documented breaking changes or a bug, anyway, it seems that from now on it downloads the artifacts on the root and not under a folder name as the one provided as name.

Therefore, to solve my issue, I had to provide the path attribute.

Was:

- name: Download Artifact
        uses: actions/download-artifact@master
        with:
          name: dist

Is now solved with

- name: Download Artifact
        uses: actions/download-artifact@master
        with:
          name: dist
          path: dist

Kuncheria-Kuruvilla added a commit to Kuncheria-Kuruvilla/chainreaction.uno that referenced this issue May 2, 2020
@Kuncheria-Kuruvilla
Copy link
Author

@peterpeterparker Thank you so much. You were right, it is a breaking change. They updated the documentation yesterday.

@peterpeterparker
Copy link

Good to know, thanks for the feedback @Kuncheria-Kuruvilla

@Binu42 Binu42 mentioned this issue May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants