Skip to content

Commit

Permalink
Fix version tag not properly passing between steps
Browse files Browse the repository at this point in the history
  • Loading branch information
w9jds committed May 22, 2024
1 parent 30f784a commit 1314374
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/check-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,8 @@ jobs:
contents: write
runs-on: ubuntu-latest

# outputs:
# new-version: ${{ steps.set-version.outputs.version }}
outputs:
new-version: ${{ needs.check-releases.outputs.firebase-tools-release }}

if: ${{ needs.check-releases.outputs.comparison == '<' }}
steps:
Expand Down Expand Up @@ -119,7 +119,7 @@ jobs:
ghcr.io/${{ github.repository }}
- name: environments
run: echo "New version Environment - ${{ env.FIREBASE_TOOLS_RELEASE }}"
run: echo "New version Environment Variable - ${{ needs.bump-version.outputs.new-version }}"

- name: Login to Docker Hub
if: github.event_name != 'pull_request'
Expand All @@ -140,5 +140,5 @@ jobs:
uses: docker/build-push-action@v5
with:
push: ${{ github.event_name != 'pull_request' }}
tags: v${{ env.FIREBASE_TOOLS_RELEASE }}
tags: v${{ needs.bump-version.outputs.new-version }}
labels: ${{ steps.meta.outputs.labels }}

0 comments on commit 1314374

Please sign in to comment.