more detailed cache key. (#1028)

* more detailed cache key. * sprintf
w7corp · Nov 15, 2017 · 062a5a6 · 062a5a6
1 parent 6dccddc
commit 062a5a6
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 9 deletions.
diff --git a/src/BasicService/Jssdk/Client.php b/src/BasicService/Jssdk/Client.php
@@ -36,11 +36,6 @@ class Client extends BaseClient
      */
     protected $url;
 
-    /**
-     * Ticket cache prefix.
-     */
-    const TICKET_CACHE_PREFIX = 'easywechat.basic_service.jssdk.ticket.';
-
     /**
      * Get config json for jsapi.
      *
@@ -82,7 +77,7 @@ public function getConfigArray(array $apis, bool $debug = false, bool $beta = fa
      */
     public function getTicket(bool $refresh = false, string $type = 'jsapi'): array
     {
-        $cacheKey = self::TICKET_CACHE_PREFIX.$this->getAppId();
+        $cacheKey = sprintf('easywechat.basic_service.jssdk.ticket.%s.%s', $type, $this->getAppId());
 
         if (!$refresh && $this->getCache()->has($cacheKey)) {
             return $this->getCache()->get($cacheKey);

diff --git a/tests/BasicService/Jssdk/ClientTest.php b/tests/BasicService/Jssdk/ClientTest.php
@@ -65,7 +65,7 @@ public function testGetTicket()
             'ticket' => 'mock-ticket',
             'expires_in' => 7200,
         ];
-        $cacheKey = Client::TICKET_CACHE_PREFIX.'123456';
+        $cacheKey = 'easywechat.basic_service.jssdk.ticket.jsapi.123456';
         $client->allows()->getCache()->andReturn($cache);
 
         // no refresh and cached

diff --git a/tests/OfficialAccount/Card/JssdkClientTest.php b/tests/OfficialAccount/Card/JssdkClientTest.php
@@ -11,7 +11,6 @@
 
 namespace EasyWeChat\Tests\OfficialAccount\Card;
 
-use EasyWeChat\BasicService\Jssdk\Client;
 use EasyWeChat\Kernel\ServiceContainer;
 use EasyWeChat\OfficialAccount\Card\JssdkClient;
 use EasyWeChat\Tests\TestCase;
@@ -29,7 +28,7 @@ public function testGetTicket()
             'ticket' => 'mock-ticket',
             'expires_in' => 7200,
         ];
-        $cacheKey = Client::TICKET_CACHE_PREFIX.'123456';
+        $cacheKey = 'easywechat.basic_service.jssdk.ticket.wx_card.123456';
         $client->allows()->getCache()->andReturn($cache);
 
         $response = new \EasyWeChat\Kernel\Http\Response(200, [], json_encode($ticket));