Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rm content related to Im-Online Pallet #5825

Merged
merged 5 commits into from
May 3, 2024
Merged

Conversation

filippoweb3
Copy link
Contributor

@filippoweb3 filippoweb3 commented Apr 25, 2024

  • Unresponsiveness
  • im-online session keys

@filippoweb3 filippoweb3 added the A1 - In Progress Not ready for review yet. label Apr 25, 2024
@filippoweb3 filippoweb3 self-assigned this Apr 25, 2024
@filippoweb3 filippoweb3 linked an issue Apr 25, 2024 that may be closed by this pull request
- imonline errors
- online message
- heartbeats
@filippoweb3
Copy link
Contributor Author

@Overkillus, can you please check if I removed the right content? Essentially, I removed im-online pallet-related stuff (slashing for unresponsiveness, heartbeat content, and online messages).

Copy link
Contributor

@Overkillus Overkillus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some relatively important nits but overall looking nice. Check here for a more comprehensive list of changes: https://github.com/orgs/paritytech/projects/119/views/15?pane=issue&itemId=61684472

I will also do one more scan of the whole staking section of the wiki to check if we didn't miss anything.

docs/learn/learn-staking.md Outdated Show resolved Hide resolved
docs/maintain/maintain-guides-how-to-chill.md Outdated Show resolved Hide resolved
@Overkillus
Copy link
Contributor

Did a quick scan and found some stale mentions:

  • :::warning Single Operators with Multiple Validators as it mentions ImOnline within Learn -> Nominator
  • The removal of a percentage of an account's DOT as a punishment for a validator acting maliciously or incompetently (e.g., equivocating or remaining offline for an extended period). in Glossary -> Slashing
  • #### Commission Fees & Slashes The network slashes a validator for a misbehavior (e.g. validator offline, equivocation, etc.) -> mentions offline slashes
  • and equivocation offenses are slashed at much higher rates than equivalent offline offenses.
  • Slashing will happen if a validator misbehaves (e.g. goes offline, attacks the network, or runs modified software)
  • Validators perform critical functions for the network, and as such, have strict uptime requirements. [...] -> mentions getting ImOnline slashed a bit further
  • Remember, even if your validator goes offline for some time, the offline slash is much more forgiving than the equivocation or parachain validity slashing.
  • Slashing penalties for being offline are much less than those for equivocation.

Please re-check if you missed some others if possible. I searched for offline, online keywords but hopefully those are all the mentions.

Not connected to disabling but I spotted it:

  • The minimal safe ratio of validators per parachain is 5:1. With a sufficiently large set of validators, the randomness of their distribution along with -> we currently use 3:1 in Kusama and we believe it is safe.

@filippoweb3 filippoweb3 added A2 - Please Review Pull request is ready for review. and removed A1 - In Progress Not ready for review yet. labels May 3, 2024
@filippoweb3 filippoweb3 requested a review from DrW3RK May 3, 2024 09:12
Copy link
Member

@DrW3RK DrW3RK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@filippoweb3 filippoweb3 merged commit dcf5afa into master May 3, 2024
3 checks passed
@filippoweb3 filippoweb3 deleted the unresponsiveness branch May 3, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A2 - Please Review Pull request is ready for review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Being offline is no longer a slashable offense
3 participants