Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addition Info NFTS Pallet #4476

Merged
merged 18 commits into from
Feb 15, 2023
Merged

Addition Info NFTS Pallet #4476

merged 18 commits into from
Feb 15, 2023

Conversation

filippoweb3
Copy link
Contributor

More information for devs willing to use the pallet to build dApps (uploading images, metadata and attributes)

@filippoweb3 filippoweb3 added the A1 - In Progress Not ready for review yet. label Feb 14, 2023
@filippoweb3 filippoweb3 self-assigned this Feb 14, 2023
@filippoweb3
Copy link
Contributor Author

@jsidorenko @SaltyCucumber
I added more info about what devs can do to upload images and metadata. Let me know if it makes sense. One question: where can I add CID when minting an item on the chain using the extrinsic tab?

@VadimSaveljev
Copy link

VadimSaveljev commented Feb 14, 2023 •
edited
Loading

@jsidorenko @SaltyCucumber I added more info about what devs can do to upload images and metadata. Let me know if it makes sense. One question: where can I add CID when minting an item on the chain using the extrinsic tab?

when updating collection: setCollectionMetadata
put CID in data field

when updating NFT: setMetadata
put CID in data field

@filippoweb3 filippoweb3 added A2 - Please Review Pull request is ready for review. and removed A1 - In Progress Not ready for review yet. labels Feb 14, 2023
@filippoweb3 filippoweb3 requested a review from DrW3RK February 14, 2023 13:38
VadimSaveljev
VadimSaveljev reviewed Feb 14, 2023
View reviewed changes
docs/learn/learn-nft-pallets.md Outdated Show resolved Hide resolved
docs/learn/learn-nft-pallets.md Outdated Show resolved Hide resolved
docs/learn/learn-nft-pallets.md Outdated Show resolved Hide resolved
docs/learn/learn-nft-pallets.md Outdated Show resolved Hide resolved
docs/learn/learn-nft-pallets.md Outdated Show resolved Hide resolved
DrW3RK
DrW3RK approved these changes Feb 15, 2023
View reviewed changes
docs/learn/learn-nft-pallets.md Outdated Show resolved Hide resolved
docs/learn/learn-nft-pallets.md Outdated Show resolved Hide resolved
docs/learn/learn-nft-pallets.md Outdated Show resolved Hide resolved
@filippoweb3 filippoweb3 merged commit 405a738 into master Feb 15, 2023
@filippoweb3 filippoweb3 deleted the update-nft-pallet-info2 branch February 15, 2023 13:05
@jsidorenko
Copy link
Contributor

"and there will be the option to attach paritytech/substrate#12437."
Can we remove this, please? That was just an idea which didn't get into the roadmap

@filippoweb3
Copy link
Contributor Author

"and there will be the option to attach paritytech/substrate#12437." Can we remove this, please? That was just an idea which didn't get into the roadmap

see this new PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VadimSaveljev VadimSaveljev VadimSaveljev left review comments

@DrW3RK DrW3RK DrW3RK approved these changes

Assignees

@filippoweb3 filippoweb3

Labels
A2 - Please Review Pull request is ready for review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@filippoweb3 @VadimSaveljev @jsidorenko @DrW3RK