Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wiki Reorg: Polkadot Launch Phases #4443

Merged
merged 16 commits into from
Feb 8, 2023
Merged

Wiki Reorg: Polkadot Launch Phases #4443

merged 16 commits into from
Feb 8, 2023

Conversation

filippoweb3
Copy link
Contributor

See this issue and this google doc for more information about the Wiki reorg.

@filippoweb3 filippoweb3 added the A1 - In Progress Not ready for review yet. label Feb 7, 2023
@filippoweb3 filippoweb3 self-assigned this Feb 7, 2023
from claims to learn-launch
to launch phases page
from redenomination to learn-launch
- claims
- redenomination
@filippoweb3 filippoweb3 changed the title Reorg Launch Phases Wiki Reorg: Polkadot Launch Phases Feb 8, 2023
@filippoweb3 filippoweb3 requested a review from DrW3RK February 8, 2023 11:37
@filippoweb3 filippoweb3 added A2 - Please Review Pull request is ready for review. and removed A1 - In Progress Not ready for review yet. labels Feb 8, 2023
Copy link
Member

@DrW3RK DrW3RK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I overlooked this when approving the move if redenomination to launch phases doc.

While I can see the merit of moving the claims page to the launch phases doc, I request you to keep the content of redenomination of DOT in a separate doc. The learn launch phases doc should seamlessly present the launch phases of DOT to the reader and with this PR, the content is pretty heavy on redenomination topic.

May be find a different place for the redenomination doc in the sidebar? (so that it is not way up in the general section)

docs/learn/learn-launch.md Outdated Show resolved Hide resolved
@DrW3RK DrW3RK added A3 - Changes Requested Pull Request needs to be updated. and removed A2 - Please Review Pull request is ready for review. labels Feb 8, 2023
@filippoweb3 filippoweb3 requested a review from DrW3RK February 8, 2023 13:23
@DrW3RK DrW3RK removed the A3 - Changes Requested Pull Request needs to be updated. label Feb 8, 2023
@filippoweb3 filippoweb3 merged commit 1ed1c15 into master Feb 8, 2023
@filippoweb3 filippoweb3 deleted the reorg-lauch-phases branch February 8, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants