Update reference hardware #3564
Conversation
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
ggwpez
force-pushed
the
update-system-reqs
branch
from
0800e1a to
4240865
Compare
Signed-off-by: bakhtin <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
| rustup install nightly-2022-05-18 | ||
| rustup target add wasm32-unknown-unknown --toolchain nightly-2022-05-18 | ||
| cargo +nightly-2022-05-18 build --release |
There was a problem hiding this comment.
do we always need to specify a specific rust nightly date? they cannot just always try latest nightly?
There was a problem hiding this comment.
We should say to check the release notes, as the rust versions are pinnned to the release that our clean room machine builds our binaries with that successfully work
There was a problem hiding this comment.
I updated the Rust compiler recommendations and suggested to check out the release notes for the exact version if one runs into the compilation errors.
There was a problem hiding this comment.
I think we use new Rust features almost as quickly as they come out so I think it's probably better to do what Shawn is suggesting: go with the latest nightly.
There was a problem hiding this comment.
I put in in here #3653
| rustup install nightly-2022-05-18 | ||
| rustup target add wasm32-unknown-unknown --toolchain nightly-2022-05-18 | ||
| cargo +nightly-2022-05-18 build --release |
There was a problem hiding this comment.
We should say to check the release notes, as the rust versions are pinnned to the release that our clean room machine builds our binaries with that successfully work
Signed-off-by: bakhtin <[email protected]>
Signed-off-by: bakhtin <[email protected]>
ggwpez
changed the title
|
@DrW3RK should be ready for a review now. Please let us know what you think. |
DrW3RK
added
A2 - Please Review
Signed-off-by: bakhtin <[email protected]>
|
@DrW3RK I addressed all of your comments. |
Fixup for #3550
TODOs for moved to #3653:
benchmark machinecommand