Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can not compile and link to Kagome scale implementation #11

Closed
drskalman opened this issue Apr 12, 2019 · 2 comments
Closed

Can not compile and link to Kagome scale implementation #11

drskalman opened this issue Apr 12, 2019 · 2 comments
Assignees

Comments

@drskalman
Copy link
Contributor

I'm trying to add a command line helper which links to and tests kagome scale implementation. See here:
https://github.com/w3f/polkadot-re-tests/blob/f--kagome-scale/test/testers/cpp-tester/CMakeLists.txt#L1

However, I get these errors when I try to compile. Could you resolve it?

-- Boost version: 1.69.0
-- Configuring done
-- Generating done
-- Build files have been written to: ./polkadot-re-tests/build
[  0%] Built target git_submodule_init
[ 10%] Building CXX object implementations/cpp/kagome/core/scale/CMakeFiles/scale.dir/basic_stream.cpp.o
In file included from ./polkadot-re-tests/implementations/cpp/kagome/core/common/buffer.hpp:13,
                 from ./polkadot-re-tests/implementations/cpp/kagome/core/scale/basic_stream.hpp:9,
                 from ./polkadot-re-tests/implementations/cpp/kagome/core/scale/basic_stream.cpp:6:
./polkadot-re-tests/implementations/cpp/kagome/core/common/result.hpp:46:21: error: expected constructor, destructor, or type conversion before ‘;’ token
   Value(T)->Value<T>;
                     ^
...
@drskalman drskalman self-assigned this Apr 12, 2019
@Warchant
Copy link

Warchant commented Apr 28, 2019

@kamilsa, we need to make sure that kagome can be included as a submodule. I added task https://soramitsu.atlassian.net/browse/PRE-138

@FlorianFranzen
Copy link
Contributor

Seems to be fixed. Kagome is included as a submodule The cpp-tester/kagome_tester builds against it fine. Scale test fixture executes successful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants