Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PCS methods return Results #39

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

PCS methods return Results #39

wants to merge 4 commits into from

Conversation

swasilyev
Copy link
Collaborator

@swasilyev swasilyev commented Dec 3, 2024

To make the PCS trait a bit more generic it now returns Result<_, ()>'s. Only the code in crate::pcs is relevant, i 'll address aggregation later.

@swasilyev swasilyev requested a review from drskalman December 3, 2024 18:42
@swasilyev swasilyev closed this Dec 3, 2024
@swasilyev swasilyev reopened this Dec 3, 2024
@swasilyev swasilyev marked this pull request as draft December 3, 2024 18:48
@swasilyev swasilyev marked this pull request as ready for review December 3, 2024 19:08
@swasilyev swasilyev requested a review from davxy December 4, 2024 09:07
Copy link
Collaborator

@davxy davxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants