Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wasm-opt-for-rust maintenance grant #1305

Merged
merged 1 commit into from
Dec 6, 2022

Conversation

brson
Copy link
Contributor

@brson brson commented Nov 25, 2022

Project Abstract

wasm-opt for Rust is a project to create Rust bindings to Binaryen's
wasm-opt
tool. It allows creators of WebAssemly toolchains
written in Rust to directly optimize their WebAssembly output instead of
calling a 3rd-party non-Rust binary.

It has been integrated into

This grant will primarily provide funding to update the wasm-opt crate
following new releases of Binaryen, after which we will also upgrade
cargo-contract and wasm-builder.

Grant level

  • Level 1: Up to $10,000, 2 approvals
  • Level 2: Up to $30,000, 3 approvals
  • Level 3: Unlimited, 5 approvals (for >$100k: Web3 Foundation Council approval)

Application Checklist

  • The application template has been copied and aptly renamed (project_name.md).
  • I have read the application guidelines. this document doesn't exist
  • A BTC, Ethereum (USDT/USDC/DAI) or Polkadot/Kusama (aUSD) address for the payment of the milestones is provided inside the application.
  • The software delivered for this grant will be released under an open-source license specified in the application.
  • The initial PR contains only one commit (squash and force-push if needed).
  • The grant will only be announced once the first milestone has been accepted (see the announcement guidelines).
  • I prefer the discussion of this application to take place in a private Element/Matrix channel. My username is: @_______:matrix.org (change the homeserver if you use a different one)

@CLAassistant
Copy link

CLAassistant commented Nov 25, 2022

CLA assistant check
All committers have signed the CLA.

@brson
Copy link
Contributor Author

brson commented Nov 25, 2022

I marked this as a level 3 because the total possible yearly budget is 72k USD, but I also included text indicating that I don't expect to spend that much, possibly significantly less. How the monthly budget is calculated is included in the text.

Note that this requests funding to fix brson/wasm-opt-rs#40, in which upstream Binaryen does not handle Unicode correctly on windows. It is a significant bugfix and will take a number of hours.

@Noc2 Noc2 self-assigned this Nov 25, 2022
@Noc2 Noc2 added the maintenance grant Maintenance grant application label Nov 25, 2022
Copy link
Collaborator

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the application. We recently discussed with our legal department that our current terms and conditions don’t fully cover maintenance agreements. Would it be possible to sign a regular contract for this via DocuSign? If so, I would mark the application as ready for review here to get the necessary number of approvals, but we would still need to sign a separate document before we merge it once enough people have approved it.

@Noc2 Noc2 added the changes requested The team needs to clarify a few things first. label Nov 25, 2022
@brson
Copy link
Contributor Author

brson commented Nov 29, 2022

@Noc2 Yes, I can sign a contract via DocuSign.

Copy link
Collaborator

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! In this case, I will mark the application as ready for review, and I’m personally happy to go ahead with it.

@Noc2 Noc2 added ready for review The project is ready to be reviewed by the committee members. and removed changes requested The team needs to clarify a few things first. labels Nov 29, 2022
Copy link
Contributor

@keeganquigley keeganquigley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @brson I agree that this will help for ink! and Substrate maintenance, happy to approve!

Copy link
Collaborator

@takahser takahser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brson I'm also happy to approve.
CC @Noc2 - Just FYI, so you can move on with the DocuSign contract.

@Noc2 Noc2 added the on hold There is an external blocker, such as another grant in progress. label Nov 30, 2022
@Noc2
Copy link
Collaborator

Noc2 commented Dec 1, 2022

@brson Just to keep you posted: We are currently drafting the contract and will share it with you shortly. The grant is already officially accepted since it has five approvals.

@Noc2
Copy link
Collaborator

Noc2 commented Dec 6, 2022

The agreement is signed, so I’m going to merge it. Thanks!

@Noc2 Noc2 merged commit 53c3c55 into w3f:master Dec 6, 2022
@Noc2 Noc2 removed the on hold There is an external blocker, such as another grant in progress. label Dec 6, 2022
@brson
Copy link
Contributor Author

brson commented Dec 8, 2022

Thanks all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance grant Maintenance grant application ready for review The project is ready to be reviewed by the committee members.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants