-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wasm-opt-for-rust-m1.md #552
Conversation
127a107
to
2c59ba8
Compare
Note that if somebody actually tries to install the binary for this "preview" version, they will need to specify the version explicitly, like |
Thank you for the excellent delivery @brson! I’ve accepted it, evaluation here. Regarding this comment in the delivery document:
That’s totally fine. If you wish you can submit an amendment to your application so that we are aware of this for the next milestone evaluation. Finally, I'll notify the finances team to pay out your invoice; please allow for up to two weeks for processing. |
Congratulations on completing the first milestone of this grant! As part of the Grants Program, we want to help grant recipients acknowledge their grants publicly. To that end, we’ve created a badge for projects that successfully deliver their first milestone. Note that it must only be used within the context of the delivered work, so please do not display it on your team or project's homepage unless accompanied by a short description of the grant. |
Thanks for the evaluation @lucasvanmol and for running tarpaulin on it. I filed an issue (brson/wasm-opt-rs#59) to look into it. It's not surprising that a tool that exercises the program in new ways would find a segfault - particularly in the low level bindings there are code paths that binaryen doesn't expect and will fail hard. I'll figure out how to get taurpaulin working, and consider running at least the high-level apis through additional analysis tools to see if they uncover any more obvious segfaults. |
Thanks for that! I mentioned it because I thought it might be of interest to the project, but note that it's not a requirement for us in terms of milestone delivery - you're of course free to look into it on your own volition. |
It's great to see this going well, looking forward to M2 😊! Nice to see that you are thinking about issues like this. |
hi @brson we transferred the payment today. |
@RouvenP I have received the payment. Thank you. |
Milestone Delivery Checklist
Link to the application pull request: w3f/Grants-Program#1070