-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenBrush follow-up delivery milestone 4 #385
OpenBrush follow-up delivery milestone 4 #385
Conversation
Thanks for the delivery @0xMarkian. We'll look into it as soon as possible. |
Co-authored-by: Aleixo Sanchez <[email protected]>
Hi @0xMarkian. I am reviewing your delivery and seem to be unable to compile it. I am getting a bunch of ❯ yarn build
yarn run v1.22.15
$ npx redspot compile
compiler version: 0.17.0
toolchain: nightly
ink: 32 matches
===== Compile lending_contract =====
[1/5] Building cargo project
Updating git repository `https://github.com/paritytech/ink`
Updating crates.io index
Compiling contracts v1.4.0 (/openbrush/openbrush-contracts/contracts)
error: custom attribute panicked
--> /openbrush/openbrush-contracts/contracts/traits/access_control/mod.rs:16:1
|
16 | #[brush::trait_definition]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: message: Couldn't open temporary storage: No such file or directory (os error 2)
error: custom attribute panicked
--> /openbrush/openbrush-contracts/contracts/traits/flashloan/mod.rs:16:1
|
16 | #[brush::trait_definition]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: message: Couldn't open temporary storage: No such file or directory (os error 2)
... |
Hi, thanks for the report! |
Hey! |
Hi @0xMarkian & @xgreenx. Thank you for the quick fix. I was able to compile and run all unit and integration tests without any further hiccups. Kudos to you for all the effort you have put into generalising the contracts and creating, implementing the standards and providing documentation. Your milestone is hereby accepted. I will forward your invoice for processing. |
Hi @0xMarkian @xgreenx @TtomaS7, we transferred the payment today. Thanks! |
Milestone Delivery Checklist
Link to the application pull request: w3f/Grants-Program#621
We have changed the ERC20 address, here is the pull request for it - w3f/Grants-Program#850