Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add KYC Validity Check #2870

Open
wants to merge 1 commit into
base: staging
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/common/src/config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ export type ConfigSchema = {
minSelfStake: number;
commission: number;
unclaimedEraThreshold: number;
enableKYC: boolean;
};
cron: {
monitor: string;
Expand Down
12 changes: 11 additions & 1 deletion packages/common/src/constraints/CheckCandidates.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import {
checkConnectionTime,
checkIdentity,
checkKusamaRank,
checkKYC,
checkLatestClientVersion,
checkOffline,
checkOnline,
Expand Down Expand Up @@ -129,6 +130,14 @@ export const checkCandidate = async (
logger.info(`${candidate.name} beefy keys not valid`, constraintsLabel);
}

const kycValid =
constraints.config?.constraints?.enableKYC == true
? await checkKYC(candidate)
: true;
if (!kycValid) {
logger.info(`${candidate.name} kyc not valid`, constraintsLabel);
}

valid =
onlineValid &&
validateValid &&
Expand All @@ -142,7 +151,8 @@ export const checkCandidate = async (
blockedValid &&
kusamaValid &&
providerValid &&
beefyValid;
beefyValid &&
kycValid;

await setValid(candidate, valid);

Expand Down
18 changes: 18 additions & 0 deletions packages/common/src/constraints/ValidityChecks.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import {
setConnectionTimeInvalidity,
setIdentityInvalidity,
setKusamaRankInvalidity,
setKYCInvalidity,
setLatestClientReleaseValidity,
setOfflineAccumulatedInvalidity,
setOnlineValidity,
Expand Down Expand Up @@ -434,3 +435,20 @@ export const checkBeefyKeys = async (
throw new Error("could not make validity check");
}
};

export const checkKYC = async (candidate: Candidate): Promise<boolean> => {
try {
const isKYC = await queries.isKYC(candidate.stash);
if (isKYC) {
const invalidityString = `${candidate.name} is not KYC`;
await setKYCInvalidity(candidate, false, invalidityString);
return false;
} else {
await setKYCInvalidity(candidate, true);
return true;
}
} catch (e) {
logger.warn(`Error trying to get kyc...`, constraintsLabel);
throw new Error("could not make validity check");
}
};
1 change: 1 addition & 0 deletions packages/common/src/db/models.ts
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@ export enum InvalidityReasonType {
KUSAMA_RANK = "KUSAMA_RANK",
PROVIDER = "PROVIDER",
BEEFY = "BEEFY",
KYC = "KYC",
}

export interface InvalidityReason {
Expand Down
15 changes: 15 additions & 0 deletions packages/common/src/db/queries/Candidate.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1053,6 +1053,21 @@ export const setBeefyKeysInvalidity = async (
);
};

export const setKYCInvalidity = async (
candidate: Candidate,
isValid: boolean,
message?: string,
): Promise<void> => {
const invalidityMessage = message ? message : `${candidate.name} is not KYC`;
setCandidateInvalidity(
candidate,
InvalidityReasonType.KYC,
isValid,
invalidityMessage,
true,
);
};

// Sets valid boolean for node
export const setValid = async (
candidate: Candidate,
Expand Down