Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readability edits: JavaScript API Surface Concerns section #228

Merged
merged 11 commits into from
Oct 8, 2020

Conversation

alice
Copy link
Contributor

@alice alice commented Jul 7, 2020

@hober hober requested review from cynthia and kenchris July 8, 2020 15:53
Copy link
Member

@torgo torgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rewording looks good to me. I don't have good answers for the two <!-- comments though.

Copy link
Contributor

@hober hober left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I think this looks great. I left some non-blocking comments.

index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Show resolved Hide resolved
@alice alice force-pushed the edit-api-surface branch from 2eda45d to 120d2f4 Compare October 8, 2020 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants