Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Say that if it doesn't fit as an attribute, it should be a method. #165

Merged
merged 1 commit into from
Apr 1, 2020
Merged

Say that if it doesn't fit as an attribute, it should be a method. #165

merged 1 commit into from
Apr 1, 2020

Conversation

dbaron
Copy link
Member

@dbaron dbaron commented Mar 30, 2020

Fixes #139.

(As discussed in Breakout A, about 4 hours ago.)

@dbaron dbaron requested a review from hober March 30, 2020 20:10
@dbaron dbaron self-assigned this Mar 30, 2020
hober
hober approved these changes Apr 1, 2020
View reviewed changes
Copy link
Contributor

@hober hober left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@hober hober merged commit b1fb167 into w3ctag:master Apr 1, 2020
hober pushed a commit that referenced this pull request Apr 1, 2020
@dbaron @hober
Say that if it doesn't fit as an attribute, it should be a method. (#165
214435f 
)

Fixes #139.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hober hober hober approved these changes

Assignees

@dbaron dbaron

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

input.valueAsDate violate "obj.attribute === obj.attribute must always hold"
2 participants
@dbaron @hober