Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR Publication Prep #1837

Merged
merged 22 commits into from
Jun 7, 2023
Merged

PR Publication Prep #1837

merged 22 commits into from
Jun 7, 2023

Conversation

egekorkan
Copy link
Contributor

@egekorkan egekorkan commented May 31, 2023

This Pull Request creates all the static files needed for the publication

  • CSS rules: Pass
  • Link Checker: Many false positives. It mentions broken fragments or internal server errors but I do not see them if I go to the link myself.
  • Pubrules: Warnings. One important one says "If it is the intention to incorporate new features in future updates of the Recommendation, please make sure to identify the document as intending to allow new features.". I think we should add this. Any opinions?

Note: these links are not necessarily up to date since they use the commit hash.

Changes I had to do to index.html:

  • comment out linking to atrisk.css
  • change IETF links to datatracker.ietf instead of tools.ietf
  • fix some HTML fragments in the links (IETF, OpenAPI, i18n)
  • change schema.org extensions to use HTTPS (i.e. http://schema.org to https://schema.org)
  • Remove at risk paragraphs in the beginning of the privacy and security sections.
  • Add recent changes section

Preview | Diff

@egekorkan egekorkan changed the title CR Publication Prep PR Publication Prep May 31, 2023
@egekorkan egekorkan marked this pull request as ready for review June 6, 2023 23:07
@egekorkan
Copy link
Contributor Author

Call of 07.06:

  • New feature note should be added

@egekorkan
Copy link
Contributor Author

We agree to merge this PR.

@egekorkan egekorkan merged commit 696e57f into main Jun 7, 2023
@mmccool
Copy link
Contributor

mmccool commented Jun 8, 2023

@egekorkan Did you run HTML tidy also? I did this in the past for CR publication and it caught a lot of HTML errors (fixes for which I then merged back into the main doc, but more may have been introduced since).

@egekorkan
Copy link
Contributor Author

@egekorkan Did you run HTML tidy also? I did this in the past for CR publication and it caught a lot of HTML errors (fixes for which I then merged back into the main doc, but more may have been introduced since).

Yes! :) I have fixed quite some more beforehand as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants