Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ContentEncoding and ContentMediaType #1157

Merged
merged 3 commits into from
Jun 17, 2021
Merged

Fix ContentEncoding and ContentMediaType #1157

merged 3 commits into from
Jun 17, 2021

Conversation

relu91
Copy link
Member

@relu91 relu91 commented Jun 3, 2021 •
edited by pr-preview bot
Loading

This PR fixes #1116. It moves contentEncoding and contentMediaType under StringSchema class. They were already placed currently in the ontology but not in the shacl file.

Preview | Diff

danielpeintner
danielpeintner requested changes Jun 3, 2021
View reviewed changes
Copy link
Contributor

@danielpeintner danielpeintner left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than my minor re-ordering/clean-up proposal it looks good!

@egekorkan
Copy link
Contributor

The preview looks good to me :)

danielpeintner
danielpeintner approved these changes Jun 7, 2021
View reviewed changes
Copy link
Contributor

@danielpeintner danielpeintner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sebastiankb
Copy link
Contributor

from today's TD session:

  • group decided to merge this PR
  • just small fixes: the list of "7bit", "8bit", "binary", "quoted-printable" and "base64" should be as an example and provided by the string type.

@relu91
fix: contentEnconding and MediaType description
eb024f8 
move examples form description to skos:examples
@relu91
Copy link
Member Author

relu91 commented Jun 17, 2021

just small fixes: the list of "7bit", "8bit", "binary", "quoted-printable" and "base64" should be as an example and provided by the string type.

@sebastiankb Should be fixed now!

@sebastiankb
Copy link
Contributor

many thanks! as agreed yesterday, I'm going to merge this PR.

@sebastiankb sebastiankb merged commit 732c5f1 into w3c:main Jun 17, 2021
takuki added a commit to takuki/wot-thing-description that referenced this pull request Jan 29, 2022
@takuki
PR w3c#1157
3ebf347
egekorkan pushed a commit to egekorkan/wot-thing-description that referenced this pull request Feb 3, 2022
@takuki @egekorkan
PR w3c#1157
f63c985
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielpeintner danielpeintner danielpeintner approved these changes

@sebastiankb sebastiankb Awaiting requested review from sebastiankb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

contentEncoding and contentMediaType should be moved under string schema
4 participants
@relu91 @egekorkan @sebastiankb @danielpeintner