Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: specify BACnet contentType #390

Merged
merged 1 commit into from
Dec 18, 2024
Merged

fix: specify BACnet contentType #390

merged 1 commit into from
Dec 18, 2024

Conversation

fennibay
Copy link
Contributor

Without specification it falls back to application/json, which is wrong
Now it will default to application/octet-stream, which means arbitrary binary data

BACnet media type #357

Without specification it falls back to application/json, which is wrong
Now it will default to application/octet-stream, which means arbitrary binary data

BACnet media type #357
Copy link

netlify bot commented Dec 16, 2024

Deploy Preview for wot-binding-templates ready!

Name Link
🔨 Latest commit 6d93327
🔍 Latest deploy log https://app.netlify.com/sites/wot-binding-templates/deploys/675ffb481f2f2d0008545017
😎 Deploy Preview https://deploy-preview-390--wot-binding-templates.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@fennibay fennibay mentioned this pull request Dec 16, 2024
@fennibay fennibay requested a review from egekorkan December 16, 2024 10:05
@ektrah ektrah added the bacnet related to bacnet protocol binding label Dec 16, 2024
Copy link
Contributor

@egekorkan egekorkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to remove the default from the contentType but it actually makes sense if a bacnet TD is processed, where a JSON Schema validator can insert it if needed.

@egekorkan
Copy link
Contributor

We discussed it in the TD call and the group is fine. The new initial connection container will help with this kind of strict contentType protocols by avoiding redeclaring it in each form.

@egekorkan egekorkan merged commit 035d8ff into main Dec 18, 2024
3 checks passed
@egekorkan egekorkan deleted the fix/bacnet/contenttype branch December 18, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bacnet related to bacnet protocol binding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants