-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding terminology "WoT Profile" #865
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two comments here:
Proposal: A technical specification that is a subset of the Thing Description specification which provides additional set of restrictive assertions such that any Consumer which conforms with the those assertions is out-of-the-box interoperable with any Thing which also conforms with those assertions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sebastiankb What does it mean to be a subset of a specification?
A profile is a collection of assertions which are neither a subset nor a superset of the assertions in the Thing Description specification, they are a separate collection of assertions with may define additional constraints and assumptions for conformant Consumers and Things.
I suspect what you're trying to say is that a Thing Description conforming to a profile can only use a subset of the features defined in the Thing Description specification, but that isn't really an accurate description either. A profile may define a subset of TD features (such as security schemes, protocol bindings, and semantic contexts) which a conformant Consumer must support, but it may also define additional assumptions (such as protocol binding defaults), some of which can't even be described declaratively in a Thing Description. That could be described as a superset of the features described in the TD specification.
This current definition of a profile has already been reviewed and landed in the WoT Profile specification, so whatever lands here will need to replace or be consistent with that definition. I prefer the current definition.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that I've started a discussion about a "Profile Mechanism 2.0" which could be much more rigidly defined, but that is a different approach to profiles than is taken in the current specification.