Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for metadata headers #5

Open
acdha opened this issue Sep 16, 2014 · 6 comments · May be fixed by #6
Open

Support for metadata headers #5

acdha opened this issue Sep 16, 2014 · 6 comments · May be fixed by #6

Comments

@acdha
Copy link

acdha commented Sep 16, 2014

I've started seeing WebVTT files which have a header like this:

WEBVTT
Kind: captions
Language: en

00:00:30.460 --> 00:00:35.380
…

If I'm reading http://dev.w3.org/html5/webvtt/#webvtt-file-structure correctly, this is a valid file with metadata headers but the validator currently reports an error.

@annevk
Copy link
Member

annevk commented Sep 17, 2014

Oh, I did not realize anyone was using my validator. Hmm. @silviapfeiffer, @foolip, do you have time to work on this?

Do browsers support this new syntax already? Not sure when I have time again to maintain this.

@silviapfeiffer
Copy link
Member

I can provide you a patch. I think my fork already deals with it.

@silviapfeiffer
Copy link
Member

Oh, also: I think browsers ignore these heaaders, which is totally fine, because they are more for authors than for browsers.

@acdha
Copy link
Author

acdha commented Sep 17, 2014

Firefox, Chrome and Safari at least ignore them — I haven't looked to see
if the values are exposed in the TextTrack object. I noticed because a new
batch of videos had them and IE11 actually rejects the entire file, which
lead me to try the validator as a first check.

@annevk
Copy link
Member

annevk commented Sep 17, 2014

If these are for authors, why are they not comments?

@foolip
Copy link
Member

foolip commented Oct 9, 2014

Unfortunately, this syntax is used for regions, search for "Region:" in http://dev.w3.org/html5/webvtt/#other-features to see an example.

There's a bug to define regions in a separate block:
https://www.w3.org/Bugs/Public/show_bug.cgi?id=24709

That being said, they are allowed per the current spec, and that I don't like them doesn't change that.

silviapfeiffer added a commit to silviapfeiffer/webvtt that referenced this issue Oct 12, 2014
We don't actually parse VTT header fields, but we ignore them for now.
Fixes w3c#5
@silviapfeiffer silviapfeiffer linked a pull request Oct 12, 2014 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants