fix: any not a keyword

[TG1999]

Signed-off-by: tushar goel [email protected]

This patch closes #436 and includes:

• A relevant test
• A relevant documentation update

[TG1999]

Hi @saschanaz I have wrote one test case for any and one for int32 I am opening another issue for writing test cases for solving #251 . Please merge this one so I can open it and start working on it.

[saschanaz]

Great work, just some nits 👍

[saschanaz]

Again while you are at it, could you remove async and constructor from this list? They are already in argumentNameKeywords so they are redundant.

[saschanaz]

Suggested change

	export const typeNameKeywords=[
	export const typeNameKeywords = [

Make sure the code format be consistent with other lines 😁

[saschanaz]

This is okay, but we could probably move any into typeNameKeywords 👍

[saschanaz]

👍 but could you rename this as int32array-keyword because

• I would keep filenames in lowercase, just for consistency
• We may get int32 in the future, so better be more specific

Sorry to be picky here 😱

[TG1999]

@saschanaz all changes made 😀

[saschanaz]

👍👍👍 Thank you for quick response!

[saschanaz]

If you want to continue your great works, #256 seems to be next easiest issue to fix.

It might be more complex than previous issues, we want to modify parser logic to allow a set of string in extended attributes. (In lib/productions/extended-attribute.js)

Probably we'll want to copy identifiers() function there and make it parse strings.

I can provide more details but it's already time to bed, so if you need more information, you might try reading existing code before I return.

[TG1999]

Hi @saschanaz I will surely like to work on this

[TG1999]

I have read the existing code from their I understood

export function identifiers(tokeniser) {
  const ids = list(tokeniser, { parser: Token.parser(tokeniser, "identifier"), listName: "identifier list" });
  if (!ids.length) {
    tokeniser.error("Expected identifiers but none found");
  }
  return ids;
}

I have to implement this functionality In lib/productions/extended-attribute.js so from where I will get the string that I have to parse

[saschanaz]

I would modify identifiers into tokens and add a new function identifiersOrStrings, all in extended-attribute.js:

function tokens(tokeniser, tokenName) {
  const toks = list(tokeniser, {
    parser: Token.parser(tokeniser, tokenName),
    listName: tokenName + " list"
  });
  if (!toks.length) {
    tokeniser.error(`Expected ${tokenName}s but none found`);
  }
  return toks;
}

function identifiersOrStrings(tokeniser) {
  return tokens(tokeniser, "identifier") || tokens(tokeniser, "string");
}

And replace existing identifiers(tokeniser) into identifiersOrStrings(tokeniser). This will allow ("str1", "str2") where we want.

[TG1999]

Okay I got it @saschanaz , will be making a PR soon then we can discuss more changes on the PR itself.

[saschanaz]

Looking forward to the PR! (If you are blocked on anything, I'm always here to help 👍)

[TG1999]

Hi, right now I am stucked with some college work, will try to get back to you by weekend and thanks for your help 😄