Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove implements statement support #98

Closed
marcoscaceres opened this issue Nov 1, 2017 · 17 comments
Closed

Remove implements statement support #98

marcoscaceres opened this issue Nov 1, 2017 · 17 comments

Comments

@marcoscaceres
Copy link
Member

marcoscaceres commented Nov 1, 2017

I think "implements" has been dropped from the IDL spec... probably when "mixin" happened...

Affected specs: whatwg/webidl#472

@tobie
Copy link
Member

tobie commented Nov 1, 2017

Yes. I'm overdue filing bugs for this. I'll look into it today. Sorry. :-/

@marcoscaceres
Copy link
Member Author

Np at all. If it’s a “yes”, than I’m happy to pull support. But I guess we should add in mixin support at the same time?

@tobie tobie closed this as completed Nov 1, 2017
@tobie
Copy link
Member

tobie commented Nov 1, 2017

Can we sync up on this issue?

@tobie tobie reopened this Nov 1, 2017
@tobie
Copy link
Member

tobie commented Nov 1, 2017

Sorry, fat fingered this.

@TimothyGu
Copy link
Member

Would be nice to have a period of time when both implements statements and mixins are supported to ease transition.

@marcoscaceres
Copy link
Member Author

marcoscaceres commented Nov 2, 2017

Would be nice to have a period of time when both implements statements and mixins are supported to ease transition.

The following tests/specs things would break:

So we should get those migrated first.

@marcoscaceres
Copy link
Member Author

(the list above is not complete... it's what I got from git grep --name-only implements ./interfaces on the WPT repo)

@marcoscaceres marcoscaceres changed the title implements statements deprecated? Remove implements statement support Nov 2, 2017
@marcoscaceres
Copy link
Member Author

@TimothyGu, could you help us notify those spec owners that we plan on making this breaking change? Probably cc @tobie, as editors might need help with reviews when adding the new syntax... otherwise, we can send PRs for the affected specs, as it's only a syntax change to the IDL in most cases, and should not affect any prose.

@marcoscaceres
Copy link
Member Author

I've moved the list of affected specs to the top of this bug... we can cross them off as they get merged.

@TimothyGu
Copy link
Member

@marcoscaceres Filed some bugs.

@tobie
Copy link
Member

tobie commented Nov 2, 2017

So just FYI, I've built a system to automate the bug filing and tracking for WebIDL changes in the future, hence the delay in doing this here. I know this delays things a bit, and I'm sorry about it.

@tobie
Copy link
Member

tobie commented Nov 2, 2017

Problem is we're now going to have plenty of dups. So if you could hold off adding more issues, that would really help.

@TimothyGu
Copy link
Member

TimothyGu commented Nov 2, 2017

@tobie Sorry about that. I'll stop doing it.

@tobie
Copy link
Member

tobie commented Nov 2, 2017

Yeah, I should have finished this way earlier. :-/

@tobie
Copy link
Member

tobie commented Nov 2, 2017

Thanks!

@marcoscaceres
Copy link
Member Author

@tobie that's awesome to hear about the automated bug filing. @TimothyGu apologies for asking you to do needless work :(

@tobie
Copy link
Member

tobie commented Nov 3, 2017

OK, finally shipped this. You can track all the things from here: whatwg/webidl#472.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants