fix: prevent empty iterable declaration (#187)

w3c · Jun 4, 2018 · 1ea9f9c · 1ea9f9c
1 parent d36f7e4
commit 1ea9f9c
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 1 deletion.
diff --git a/lib/webidl2.js b/lib/webidl2.js
@@ -692,7 +692,7 @@
       if (ret.type !== 'maplike' && ret.type !== 'setlike')
         delete ret.readonly;
       if (consume("<")) {
-        ret.idlType = [type_with_extended_attributes()] || error(`Error parsing ${ittype} declaration`);
+        ret.idlType = [type_with_extended_attributes() || error(`Error parsing ${ittype} declaration`)];
         if (secondTypeAllowed) {
           if (consume(",")) {
             ret.idlType.push(type_with_extended_attributes());

diff --git a/test/invalid/idl/iterable-empty.widl b/test/invalid/idl/iterable-empty.widl
@@ -0,0 +1,3 @@
+interface X {
+    iterable<>;
+};
diff --git a/test/invalid/json/iterable-empty.json b/test/invalid/json/iterable-empty.json
@@ -0,0 +1,4 @@
+{
+    "message": "Got an error during or right after parsing `interface X`: Error parsing iterable declaration",
+    "line": 2
+}