Update userScripts.execute() to receive multiple js sources #745
Conversation
Updated as discussed in w3c#477 (comment)
…multiplesources Update userScripts.execute() to receive multiple js soruces
EmiliaPaz
changed the title
Rob--W
changed the title
There was a problem hiding this comment.
Can we specify what the behavior should be when a runtime error occurs while executing one of the ScriptSources?
Options:
- Interrupt execution and propagate error to the caller.
- Log error and continue executing the next script.
Since executeScript is specified to propagate the result to the caller, it would make sense to propagate errors.
On the other hand, if registered declaratively, the expected behavior is to run them all (and uncaught errors be reported to the console).
There is something to say for either approach.
For comparison, where I checked Chrome's current scripting.executeScript implementation will eventually be handled by the generic logic that is shared between declarative scripts and executeScript (ScriptInjection::InjectJs. This will ultimately just execute all scripts and swallow errors (in WebScriptExecutor::Execute). Now that I see this code, I guess that it also explains why scripting.executeScript does not expose errors in Chrome (https://issues.chromium.org/issues/40205757).
Updated as discussed in #477 (comment)