-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add interface definitions for Chromium #359
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This patch includes files that are specific to legacy Chrome Apps, as well as private APIs.
The Chrome Apps APIs can certainly be omitted, as they (chrome/common/apps/) cannot be used in any extension.
If we do that, then we can reduce the number of results from 203 to:
- Chromium code search:
(file:^chrome/common/extensions/api/ OR file:^extensions/common/api/) (file:.json$ OR file:.idl)
If I omit private and clear internal implementation details, then we have:
- Chromium code search:
(file:^chrome/common/extensions/api/ OR file:^extensions/common/api/) (file:.json$ OR file:.idl) -file:_private -file:_internal
There are still many non-public APIs. If you'd like to be extra precise, you could look at entries with "extension_types" containing "extension" WITHOUT "whitelist" at chrome/common/extensions/api/_permission_features.json and extensions/common/api/_permission_features.json. This will give a list of public APIs (filter by "channel": "stable"
to only get stable APIs, but for the purpose of this spec we probably accept pre-release API definitions too). Next, filter by APIs that depend on non-public permissions (listed at chrome/common/extensions/api/_api_features.jso and extensions/common/api/_api_features.json).
interfaces/chromium/chrome-common-extensions-api/autofill_private.idl
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a mix of idl and json files. This is a good start, but i feel that having a common format (for one platform) would be consistent. Comments?
IMO that would be ideal, but for better or worse Chromium currently uses a mix of formats. Normalizing them here is out of scope. This PR only aims to provide a snapshot of Chromium's interface definitions and provide guidance on how to manually update them in the future. |
$ find . -name *_private* | xargs git rm
$ find . -name *_private* | xargs git rm
57a296e
to
2a74ba2
Compare
SHA: 10591b2 Reason: push, by dotproto Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 10591b2 Reason: push, by dotproto Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This pull request introduces an initial set of WebExtensions definitions for the Chromium project. Additional details on how the data was gathered can be found in
interfaces/chromium/README.md
.