Add browser.secureStorage proposal #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rob--W
reviewed
Feb 23, 2022
added 2 commits
February 23, 2022 15:34
dotproto
reviewed
Mar 2, 2022
dotproto
approved these changes
Mar 2, 2022
Co-authored-by: Simeon Vincent <[email protected]>
mukul-p
approved these changes
Mar 3, 2022
zombie
approved these changes
Mar 9, 2022
|
|
||
| This proposal is drafted by the team at 1Password. Our [extension](https://chrome.google.com/webstore/detail/1password-%E2%80%93-password-mana/aeblfdkhhhdcdjpifhhbdiojplfjncoa?hl=en) is available for Chrome, Firefox, Safari and Edge and has more than 2M weekly active users in the Chrome Web Store alone. We would be quick to implement this in conjunction with or in place of our current Native Messaging solution. | ||
|
|
||
| The Dashlane browser extension, also a password manager with over 4M weekly active users in the Chrome Web Store, currently provides a remember me and biometric authentication feature in its extension to make repeated authentication easier. They would also be very quick to implement this in place of their solution which requires a network connection, as they don’t leverage a native application to interface with native storage. |
There was a problem hiding this comment.
Do we have a public comment of someone from Dashlane supporting this proposal? If not, perhaps better to leave this for a later PR they could submit.
There was a problem hiding this comment.
@bradcush reached out out-of-band and shared this quote which he was happy for us to use in the proposal. I'm fairly sure he's happy with it being included here but I'll ask if he can drop an approval so we have everything documented in one place.
There was a problem hiding this comment.
This quote is good for us, confirming here publicly on behalf of Dashlane, thanks!
zombie
reviewed
Mar 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the proposal from #154 to a new proposals/ folder in the repository. As discussed at the end of the last meeting, my hope is that this makes it easier to collaborate on the proposal while also providing us with a commit history and issue tracker that we can use while moving this forward as a community.
For now, this is very close to a direct port from the shared document. I plan to start making more changes in future PRs.