-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish minutes of 2022-02-17 meeting #166
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like something went wrong and the notes are missing.
923b665
to
3f0fc01
Compare
Thanks. I had forgotten to check in the file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a very minor and a medium sized clarification. Once those are merged into the PR I think the we're good to merge it into main.
* [jack] if arbitrary code is not allowed in MV3, how can Tampermonkey run user scripts? | ||
* [simeon] The scripting API will be expanded to support user scripts. (post meeting edit: we to gate access to this capability similar to Chrome's current "allow access to file URLs" control) | ||
* [tomislav] Two features are being mixed up in this discussion: 1) running scripts in the main world synchronously and 2) running arbitrary scripts (not shipped with extension) in the main world from a content script. | ||
* [simeon] The world property of the scripting API allows the selection of the world. We believe that this allows extensions to schedule scripts in the desired order. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* [simeon] The world property of the scripting API allows the selection of the world. We believe that this allows extensions to schedule scripts in the desired order. | |
* [simeon] The world property of the scripting API allows the selection of the world. We believe that this allows extensions to schedule scripts in the desired order. | |
* [simeon] Let's try a different framing. In order to inject a content script into the main world, an extension developers would declare a content script object in manifest.json, but add a new "world" property. This prop takes a value of either MAIN or ISOLATED. The scripting API's dynamic content script support will also be expanded to support this property. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added this line to the notes, but I note that this comment is part of a larger conversation during the meeting where I and other participants tried to emphasize that there are use cases where extensions want to decide at runtime where main world scripts are injected by the content script. The "func" feature of scripting.executeScript
is to allow extensions to run logic without being forced to run create separate files for every bit of logic.
Neither dynamic nor static (manifest) content scripts would allow extensions to synchronously run main world scripts from the content script.
3f0fc01
to
20b64b9
Compare
Merging again because the next meeting will happen tomorrow. Let's try to get this merged sooner next time. |
Generated from https://docs.google.com/document/d/1QkwhEMtMS67JBUkl_WVPZ4lRSKoWcQNlLJSf_GwSXg8/edit using the tool and process from #105.
During this meeting we discussed or mentioned #159, #160, #163, #99, #98, #96, #95, #97, #120, #154.