Make return types of SubtleCrypto methods more specific #388
Conversation
Also, reformat the WebIDL.
There was a problem hiding this comment.
Is there a reason to keep the methods multiline? Pretty much every other specification I know keeps these on a single line.
I did not check all methods in detail, but those I did check seemed to line up type-wise with how we resolve the promises in WebKit. Our IDL uses any however and I'm not sure we'd get benefit from types, but still seems like an improvement.
|
Mainly just readability I'd say; the declarations end up being really long when put on a single line, and will become even more so if we add #73 (comment), where a single parameter might be a |
|
Hmm, but do we want to build on the current API shape? Filed #389 on that. |
|
I'll make a PR to find out whether folks are happy with that, if that doesn't end up happening we can always reconsider here :) |
SHA: 0ac8c1b Reason: push, by twiss Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Also, reformat the WebIDL.
Resolves #293.
Preview | Diff