Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dead writes to CryptoKey.extractable in HKDF/PBKDF2.importKey #379

Merged
merged 1 commit into from
Oct 25, 2024

Commits on Oct 25, 2024

  1. Remove dead writes to CryptoKey.extractable in HKDF/PBKDF2.importKey

    When these steps execute, it is know due to an earlier step that the
    argument 'extractable' is false, and that the internal slot will not be
    read before being overwritten again by SubtleCrypto.importKey:
    
    https://w3c.github.io/webcrypto/#SubtleCrypto-method-importKey
    
    Therefore, it is a dead write. Removing it makes it more similar to all
    other importKey operations, which do not write the [[extractable]]
    internal slot either.
    BenWiederhake committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    c3d26fb View commit details
    Browse the repository at this point in the history