Add OpusEncoderConfig parameters #594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalecurtis
reviewed
Oct 20, 2022
Closed
aboba
requested changes
Oct 21, 2022
aboba
approved these changes
Oct 23, 2022
dalecurtis
reviewed
Oct 24, 2022
|
I will leave some time for @padenot to comment before merging. I am working on the Chromium implementation. |
|
This has been open for a few extra days, I will go ahead and merge. If there's anything that needs updating, please let me know @padenot. Thanks for the reviews! |
github-actions bot
added a commit
that referenced
this pull request
Nov 1, 2022
SHA: 7cd5b40 Reason: push, by tguilbert-google Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Nov 1, 2022
SHA: 7cd5b40 Reason: push, by tguilbert-google Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Nov 1, 2022
SHA: 7cd5b40 Reason: push, by tguilbert-google Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Nov 1, 2022
SHA: 7cd5b40 Reason: push, by tguilbert-google Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Nov 1, 2022
SHA: 7cd5b40 Reason: push, by tguilbert-google Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
to tguilbert-google/webcodecs
that referenced
this pull request
Nov 1, 2022
SHA: 7cd5b40 Reason: push, by tguilbert-google Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Nov 1, 2022
SHA: 7cd5b40 Reason: push, by tguilbert-google Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
to tguilbert-google/webcodecs
that referenced
this pull request
Nov 1, 2022
SHA: 7cd5b40 Reason: push, by tguilbert-google Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Nov 1, 2022
SHA: 7cd5b40 Reason: push, by tguilbert-google Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
to tguilbert-google/webcodecs
that referenced
this pull request
Nov 1, 2022
SHA: 7cd5b40 Reason: push, by tguilbert-google Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Nov 1, 2022
SHA: 7cd5b40 Reason: push, by tguilbert-google Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
to tguilbert-google/webcodecs
that referenced
this pull request
Nov 1, 2022
SHA: 7cd5b40 Reason: push, by tguilbert-google Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Nov 1, 2022
SHA: 7cd5b40 Reason: push, by tguilbert-google Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
to tguilbert-google/webcodecs
that referenced
this pull request
Nov 1, 2022
SHA: 7cd5b40 Reason: push, by tguilbert-google Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Nov 1, 2022
SHA: 7cd5b40 Reason: push, by tguilbert-google Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
to tguilbert-google/webcodecs
that referenced
this pull request
Nov 1, 2022
SHA: 7cd5b40 Reason: push, by tguilbert-google Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Nov 1, 2022
SHA: 7cd5b40 Reason: push, by tguilbert-google Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
to tguilbert-google/webcodecs
that referenced
this pull request
Nov 1, 2022
SHA: 7cd5b40 Reason: push, by tguilbert-google Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Nov 1, 2022
SHA: 7cd5b40 Reason: push, by tguilbert-google Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
to tguilbert-google/webcodecs
that referenced
this pull request
Nov 1, 2022
SHA: 7cd5b40 Reason: push, by tguilbert-google Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Nov 1, 2022
SHA: 7cd5b40 Reason: push, by tguilbert-google Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
to tguilbert-google/webcodecs
that referenced
this pull request
Nov 1, 2022
SHA: 7cd5b40 Reason: push, by tguilbert-google Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
to tguilbert-google/webcodecs
that referenced
this pull request
Nov 1, 2022
SHA: 7cd5b40 Reason: push, by tguilbert-google Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Nov 1, 2022
SHA: 7cd5b40 Reason: push, by tguilbert-google Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
to tguilbert-google/webcodecs
that referenced
this pull request
Nov 1, 2022
SHA: 7cd5b40 Reason: push, by tguilbert-google Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Nov 1, 2022
SHA: 7cd5b40 Reason: push, by tguilbert-google Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
to tguilbert-google/webcodecs
that referenced
this pull request
Nov 1, 2022
SHA: 7cd5b40 Reason: push, by tguilbert-google Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Nov 1, 2022
SHA: 7cd5b40 Reason: push, by tguilbert-google Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
to tguilbert-google/webcodecs
that referenced
this pull request
Nov 1, 2022
SHA: 7cd5b40 Reason: push, by tguilbert-google Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
to tguilbert-google/webcodecs
that referenced
this pull request
Nov 1, 2022
SHA: 7cd5b40 Reason: push, by tguilbert-google Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
to tguilbert-google/webcodecs
that referenced
this pull request
Nov 1, 2022
SHA: 7cd5b40 Reason: push, by tguilbert-google Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
to tguilbert-google/webcodecs
that referenced
this pull request
Nov 1, 2022
SHA: 7cd5b40 Reason: push, by tguilbert-google Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds in-band-FEC, DTX and complexity configuration knobs to the Opus encoder.
This should fix #244 and #527